[ open-vm-tools-Tracker-3371547 ] patches to allow vmtools to be built with uclibc/buildroot

[SourceForge.net <no...@so...>]

Tracker item #3371547, was opened at 2011-07-19 09:26
Message generated for change (Comment added) made by mvanzin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=3371547&group_id=204462

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: https://www.google.com/accounts ()
Assigned to: Nobody/Anonymous (nobody)
Summary: patches to allow vmtools to be built with uclibc/buildroot

Initial Comment:
With the attached patches, vmtools will be able to be built for uclibc. Tested successfully in a buildroot environment.


----------------------------------------------------------------------

>Comment By: Marcelo Vanzin (mvanzin)
Date: 2011-07-21 10:42

Message:
Thanks. I'll ping our legal department since generally they haven't been
very good in processing those.

----------------------------------------------------------------------

Comment By: https://www.google.com/accounts ()
Date: 2011-07-21 04:20

Message:
Contributor agreement sent.

----------------------------------------------------------------------

Comment By: https://www.google.com/accounts ()
Date: 2011-07-21 04:05

Message:
I've substituted patch #4 with a much simpler version -- just moves
NO_FLOATING_POINT ifdef to exclude one function. The rest of the code that
was problematic can be stubbed out by compiling with NO_FLOATING_POINT. So
basically these patches just modify some ifdef's now. Will submit
contributor agreement.

----------------------------------------------------------------------

Comment By: Marcelo Vanzin (mvanzin)
Date: 2011-07-20 10:08

Message:
For the libc bits, I don't think we can accept those into our repository,
unless you manage to get the copyright owner to sign off the copyright on
those bits to VMware (which I think is unlikely to happen...).

----------------------------------------------------------------------

Comment By: https://www.google.com/accounts ()
Date: 2011-07-20 01:08

Message:
Hi,

All patches except one are nothing more than adding an extra #if defined
so signing and returning the approval form isn't a problem. Patch number #4
is more problematic however since the code is lifted off libc. What's the
contribution policy on that?

----------------------------------------------------------------------

Comment By: Marcelo Vanzin (mvanzin)
Date: 2011-07-19 10:30

Message:
Thanks for taking the time to do this, but we can't accept any patches
unless you follow the instructions at:
http://open-vm-tools.sourceforge.net/contribute.php

Lots of this code is shared with our closed-sourced products, so we can't
just merge (L)GPL code into our code base without being able to change the
license.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=3371547&group_id=204462