Re: Inconsistent use of the VMTOOLS_USE_GLIB define - build broken?

[Marcelo V. <mv...@vm...>]

Hi John,

On 07/14/2011 03:36 PM, John Wolfe wrote:
> lib/rpcIn/rpcin.c & rpcin.h have 2 forms of the functions:
> 
>    RpcIn_Construct()
>    RpcIn_Start()
> 
> with a different number of parameters and parameter type.  The
> selection is controlled by the define VMTOOLS_USE_GLIB.

> lib/rpcIn contains no similar specification in the Makefile.am
> and as a result, rpcin.c is compiled WITHOUT the VMTOOLS_USE_GLIB
> define and thus the wrong form of the functions are compiled.

rpcin.c is currently compiled twice in open-vm-tools: once when compiling
lib/rpcIn, the second time when compiling libvmtools (it's listed in the source
files list in libvmtools/Makefile.am). The second time, VMTOOLS_USE_GLIB is defined.

Since there's no more code that uses the non-glib version in open-vm-tools, I
have already changed this in our internal source tree so it's only done once.
But even in the current released sources for open-vm-tools, the makefiles should
be doing the right thing.

As for why this seems to influence heartbeats in your case, I don't know. The
heartbeat is not an explicit message, it's recorded implicitly by just polling
the backdoor, which is what the rpcIn library does. So if vmtoolsd is running
and running the rpcIn loop, the heartbeat should be updated.

-- 
- Marcelo