Re: [PATCH] vmxnet: fix irq naming to match network convention

[Marcelo V. <mv...@vm...>]

Hi Stephen,

I sent your e-mail to the appropriate team inside VMware and they'll take care
of it. Thanks!

On 03/31/2011 09:18 AM, Stephen Hemminger wrote:
> The vmxnet driver always requests irq with name of 'vmxnet' which
> is incorrect. It causes multiple entries in /proc/interrupts and confuses
> scripts like irqbalance that try and manage smp affinity on network cards.
> 
> The fix is simple, just use the standard convention of putting device
> name in the irq name. This applies to all kernel versions.
> 
> Also, the 'lp->name' structure element is always constant and no longer
> used and could be eliminated.
> 
> Signed-off-by: Stephen Hemminger <she...@vy...>
> 
> --- a/modules/linux/vmxnet/vmxnet.c	2011-03-31 09:12:30.258151524 -0700
> +++ b/modules/linux/vmxnet/vmxnet.c	2011-03-31 09:12:55.516883147 -0700
> @@ -1915,7 +1915,7 @@ vmxnet_open(struct net_device *dev)
>     }
>  
>     if (dev->irq == 0 ||	request_irq(dev->irq, &vmxnet_interrupt,
> -			            COMPAT_IRQF_SHARED, lp->name, (void *)dev)) {
> +			            COMPAT_IRQF_SHARED, dev->name, (void *)dev)) {
>        return -EAGAIN;
>     }


-- 
- Marcelo