[Opalvoip-devel] Small patch for master opal git fixing crash during incoming calls

[Bertrand T. <ber...@gm...>]

Hi,

I had to patch opal (using conopal sample) with last git master, to fix a
crash
due to commit 1775ce: "Fixed various issues with Cisco SIP servers and
emulating a Cisco device."

the crash appens line 578 of file src/sip/sipcon.cxx
the "handler" variable is nullptr in this case, so adding "if (handler)"
fixes the problem..

whole code block :

 bool ciscoEndpoint = false;
 if (m_lastReceivedINVITE != NULL) {
    PSafePtr<SIPHandler> handler =
m_sipEndpoint.FindSIPHandlerByUrl(m_lastReceivedINVITE->GetMIME().GetTo(),
SIP_PDU::Method_REGISTER, PSafeReference);
    if (handler)
        ciscoEndpoint = dynamic_cast<SIPRegisterHandler
*>(&*handler)->GetParams().m_compatibility == SIPRegister::e_Cisco;
  }


Cheers,
and thanks for this amazing piece of software, bye.

BT.