[Opalvoip-svn] SF.net SVN: opalvoip:[34796] ptlib/trunk/src/ptlib/unix/socket.cxx

[<wil...@us...>]

Revision: 34796
          http://sourceforge.net/p/opalvoip/code/34796
Author:   willamowius
Date:     2016-04-27 01:43:05 +0000 (Wed, 27 Apr 2016)
Log Message:
-----------
fix segfault: if prefixbits == 0, i goes to -1, causing an out of bounds read

Modified Paths:
--------------
    ptlib/trunk/src/ptlib/unix/socket.cxx

Modified: ptlib/trunk/src/ptlib/unix/socket.cxx
===================================================================
--- ptlib/trunk/src/ptlib/unix/socket.cxx	2016-04-26 10:50:14 UTC (rev 34795)
+++ ptlib/trunk/src/ptlib/unix/socket.cxx	2016-04-27 01:43:05 UTC (rev 34796)
@@ -725,7 +725,7 @@
     memset(&fullmask, 0, sizeof(fullmask));
     memcpy(&fullmask, mask, std::min((size_t)masklen, sizeof(fullmask)));
   }
-  for(unsigned i=128; i >= prefixbits; --i) {
+  for(unsigned i=128; i > prefixbits; --i) {
     ResetBit(i, fullmask);
   }
   return PIPSocket::Address(16, (BYTE*)&fullmask);

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.