[Opalvoip-svn] SF.net SVN: opalvoip:[34724] opal/branches/v3_16/src/sip/sipcon.cxx

[<rjo...@us...>]

Revision: 34724
          http://sourceforge.net/p/opalvoip/code/34724
Author:   rjongbloed
Date:     2016-03-28 14:56:18 +0000 (Mon, 28 Mar 2016)
Log Message:
-----------
Plugged race condition where after receiving a BYE and sending 200, we try and send another BYE. THis is mostly cosmetic, and it should be noted this behaviour can still happen, as there is an "over the wire" race condition which the protocol is designed to deal with.

Modified Paths:
--------------
    opal/branches/v3_16/src/sip/sipcon.cxx

Modified: opal/branches/v3_16/src/sip/sipcon.cxx
===================================================================
--- opal/branches/v3_16/src/sip/sipcon.cxx	2016-03-28 14:36:44 UTC (rev 34723)
+++ opal/branches/v3_16/src/sip/sipcon.cxx	2016-03-28 14:56:18 UTC (rev 34724)
@@ -2674,12 +2674,13 @@
 
   SIPTransaction * response = new SIPResponse(GetEndPoint(), request, SIP_PDU::Successful_OK);
   response->Send();
+
+  releaseMethod = ReleaseWithNothing;
   
   if (IsReleased()) {
     PTRACE(2, "Already released " << *this);
     return;
   }
-  releaseMethod = ReleaseWithNothing;
 
   m_dialog.Update(request);
   UpdateRemoteAddresses();

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.