Re: [Opalvoip-devel] CallingPartyNumber not set in H323 PDU
Brought to you by:
csoutheren,
rjongbloed
From: Robert J. <ro...@vo...> - 2013-05-17 08:25:01
|
Good find! I have applied the patch to the Eridani head SVN. *Robert Jongbloed* OPAL/OpenH323/PTLib Architect and Co-founder. Commercial support at http://www.voxlucida.com.au /Travelling, so email responses may be slow!/ Robert. On 17/05/13 5:05 PM, Tobias Stähli wrote: > > Hello, > > While our testing, we noticed, that the CallingPartyNumber on H323 > Calls is not set as we expect. After some searching, we think we have > found the problem. It's in H323SignalPDU::SetQ931Fields where > OPAL_OPT_CALLING_PARTY_NUMBER is checked. If the number is NOT empty, > the number is overwritten with either the local name or an alias. If > the number however is empty( as in our case since we do not use > OPAL_OPT_CALLING_PARTY_NUMBER), the number stays empty and the > corresponding q931 field is not set. > > This problems is in OPAL 3.12.3 as well as in the current Trunk. > > Removing the NOT in the if-condition made it work as expected again. > > Code in question: > > H323pdu.cxx, Line 1352 > > void H323SignalPDU::SetQ931Fields(const H323Connection & connection, > bool insertPartyNumbers) > > { > > const PStringList & aliases = connection.GetLocalAliasNames(); > > PString localName = connection.GetLocalPartyName(); > > PString displayName = connection.GetDisplayName(); > > PString number = > connection.GetStringOptions()(OPAL_OPT_CALLING_PARTY_NUMBER); > > if (!number.IsEmpty()) { // <ßBUG Here, one ! too many. > > if (OpalIsE164(localName)) > > number = localName; > > else { > > for (PStringList::const_iterator alias = aliases.begin(); alias > != aliases.end(); ++alias) { > > if (OpalIsE164(*alias)) { > > number = *alias; > > break; > > } > > } > > } > > } > > Kind Regards > Tobias Stähli > > NovaLink GmbH |Zürcherstrasse 310 |8500 Frauenfeld |Switzerland > |www.novalink.ch <http://www.novalink.ch> > Phone: +41 52 762 66 04 |Fax: +41 52 762 66 14 > |tob...@no... <mailto:tob...@no...> > Support Hotline: +41 52 762 66 77 |Online Support Request: > www.novalink.ch/support <http://www.novalink.ch/support> > > > > ------------------------------------------------------------------------------ > AlienVault Unified Security Management (USM) platform delivers complete > security visibility with the essential security capabilities. Easily and > efficiently configure, manage, and operate all of your security controls > from a single console and one unified framework. Download a free trial. > http://p.sf.net/sfu/alienvault_d2d > > > _______________________________________________ > Opalvoip-devel mailing list > Opa...@li... > https://lists.sourceforge.net/lists/listinfo/opalvoip-devel |