#621 SIP Re-registration doesn't make IsRegistered() return true

[Alfred Neumayer]

With opal from Git branch v3_20 at rev 74d5157a7d20a6e2d394c1f34ec554d438d3bee4 (newer ones from v3_20 FTBFS with Makefile:2477: tests/.deps/test_opus_projection.Po: No such file or directory) the following scenario causes problems:

• Register successfully against Asterisk
• Comment out the entry from Asterisk
• Let re-register fail
• Re-apply entry back into Asterisk

Expected result:

• Re-registration succeeds with SIPEndpoint::IsRegistered() returning true

Actual result:

• Re-registration succeeds but IsRegistered() returns false

This makes it hard to check whether an opal-using program successfully is back on track via SIP.

I know re-registration succeeded because Asterisk is not complaining anymore about an unsuccessful authentication attempt.

[Alfred Neumayer]

Additional info:

The following snippet returns "No handler found with this call ID":

if (!m_sipEP->IsRegistered(iter->m_param.m_addressOfRecord)) {
    qDebug() << "Out-of-order re-registration:" << (const char*)iter->m_param.m_addressOfRecord;

    auto handler = m_sipEP->FindSIPHandlerByCallID(iter->m_param.m_addressOfRecord, PSafeReference);

    if (!handler) {
        qDebug() << "No handler found with this call ID";
    } else {
        qDebug() << "Handler state:" << handler->GetState();
    }

    iter->Stop(*m_sipEP);
    iter->Start(*m_sipEP);
}

Where ::Stop() and ::Start call SIPEndPoint::Register() and SIPEndPoint::Unregister() respectively.

And in opal traces it shows that the SIPEndPoint is trying to .Append() another handler which fails with Duplicate handler for Method/AOR/Package="5sip:<number>@<address>;transport=udp" after a re-registration. Right before that it complains about Could not find active REGISTER for sip:<number>@<address>;transport=udp