From: Anthony B. <ant...@ir...> - 2009-09-11 09:22:14
|
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type"> <title></title> </head> <body bgcolor="#ffffff" text="#000000"> Hi!<br> I've finally installed svn version of Opal2 on a test server and I have a few comments/questions:<br> <br> -First, I've found a bug in my "typed WSDL addon": on a freshly installed opal2 with the addon, you cannot deploy any service. So I attach a patched file to put in OpalSOAPRequestFilter package. Briefly, the problem was that the file WEB-INF/server-config.wsdd (which is used by the filter) doesn't exists when no service is deployed.<br> <br> -I see you've included c3p0 and mysql connector packages (which is great!), but their are not the latest versions available (0.9.1.1 instead of 0.9.1.2 for c3p0 and 5.1.0 instead of 5.1.8 for mysql). I have no particular problem with these older versions but I was wondering if there was a reason for that...<br> -Speaking about c3p0, I've seen you haven't included the "c3p0.preferredTestQuery=SELECT 1;" property. Is this intended? It can be defined in $OPAL_SOURCES/etc/hibernate-opal.cfg.xml using "<property name="c3p0.preferredTestQuery">SELECT 1;</property>". Looking at the doc, it seems like it makes testing database availability faster.<br> <br> -There's also a new bug in svn: our servers are not running on the 8080 port, so the dashboard has some problems with it (maybe you are aware of it?). From what I have seen, there's at least one hard-coded 8080 port in webapps/opal2/dashboard-jsp/serviceList.jsp on line 51 (there may be the same bug in other files). Making this configurable would be quite useful!<br> <br> Apart from that, Opal2 is running smoothly and the new application list is great!<br> <br> You told me you could give me commit access to svn: if you're still ok with that, do I need to create a sourceforge account?<br> <br> Cheers<br> Anthony<br> <br> Sriram Krishnan wrote: <blockquote cite="mid:0EA...@sd..." type="cite">Hello Anthony, <div><br> </div> <div>I have committed your changes into SVN, and also added configuration and jars for c3p0 and mysql. I tested everything and it seems to be working fine. Please check out the latest version from SVN and let me know if there are any issues.</div> <div><br> </div> <div>This will be part of the next Opal release that we are planning for end of this month. Thanks again for your contribution!</div> <div><br> </div> <div>Cheers,</div> <div>Sriram</div> <div><br> <div> <div>On Sep 2, 2009, at 5:28 AM, Anthony Bretaudeau wrote:</div> <br class="Apple-interchange-newline"> <blockquote type="cite"> <div bgcolor="#ffffff" text="#000000"> Hi!<br> After testing, I've managed to make job exec time visualization work with the following code (replace line 389 with it in src/edu/sdsc/nbcr/opal/dashboard/persistence/DBManager.java):<br> <br> }else if (dialect.equals("org.hibernate.dialect.MySQLDialect")){<br> //this is MySQL<br> query = "select jobInfo.start_time_date as date, " +<br> //number of day <br> " avg( ( last_update_date - start_time_date ) * 86400 + " +<br> //plus number of seconds (epoch returns seconds!)<br> " ( time_to_sec(last_update_time) - time_to_sec(start_time_time) )) as average " + queryTail;<br> }<br> <br> Feel free to include this in next release if it can help other users.<br> Thanks.<br> Anthony<br> <br> Anthony Bretaudeau a écrit : <blockquote cite="mid:4A9...@ir..." type="cite"> <pre wrap="">Oh yes, the exec time has a problem. I hadn't noticed that. Is this the only SQL request using local SQL dialect? In this case, something like "unix_timestamp( last_update_time - start_time_time ) as average" should work for MySQL (copying the rest of the request from PostgreSQL). If I have time, I'll try to test it. Thanks Anthony Luca Clementi a écrit : </pre> <blockquote type="cite"> <pre wrap="">Anthony Bretaudeau wrote: </pre> <blockquote type="cite"> <pre wrap="">Hi! We've had a problem using MySQL database for storing opal2 jobs data instead of the default HSQLDB. It turned out it was a timeout problem which is quite well described at the following address: <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.databasesandlife.com/automatic-reconnect-from-hibernate-to-mysql/">http://www.databasesandlife.com/automatic-reconnect-from-hibernate-to-mysql/</a>. Briefly: mysql closes connection after an 8h timeout (which is quite frequent for us, but not for servers where there is more activity). We solved it by using c3p0 to manage database connection. Here is what we have done to use it: </pre> </blockquote> <pre wrap="">Anthony, I expect the dashboard to have some problem visualizing the exec time of your jobs. Have a look at line 365: <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://opaltoolkit.svn.sourceforge.net/viewvc/opaltoolkit/tags/opal2-core-2.0.0/src/edu/sdsc/nbcr/opal/dashboard/persistence/DBManager.java?revision=381&view=markup">http://opaltoolkit.svn.sourceforge.net/viewvc/opaltoolkit/tags/opal2-core-2.0.0/src/edu/sdsc/nbcr/opal/dashboard/persistence/DBManager.java?revision=381&view=markup</a> Unfortunately I could not find a way to make the query working using Hibernate SQL and I had to use the local SQL dialect. Given that I think we should start using some connection manager since it is also recommended by the Hibernate guys. Sincerely, Luca </pre> <blockquote type="cite"> <pre wrap="">-Added c3p0 package in $opal_sources/lib/ and modified build.xml consequently -Created $opal_sources /etc/c3p0.properties and added " c3p0.preferredTestQuery=SELECT 1; " in it. -In build.xml, after <include name="OpalState.hbm.xml"/> added <include name="c3p0.properties"/> -In $OPAL_SOURCES/etc/hibernate-opal.cfg.xml, replaced: <!-- JDBC connection pool (use the built-in) --> <!--<property name="connection.pool_size">1</property>--> By these lines: <!-- JDBC connection pool (use c3p0) --> <property name="c3p0.min_size">1</property> <property name="c3p0.max_size">20</property> <property name="c3p0.timeout">1800</property> <property name="c3p0.max_statements">50</property> <property name="c3p0.idle_test_period">1800</property> <property name="connection.provider_class">org.hibernate.connection.C3P0ConnectionProvider</property> Maybe it would be a good idea to include it in a future version of opal? Bye! </pre> </blockquote> </blockquote> <pre wrap=""><!----> ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://p.sf.net/sfu/bobj-july">http://p.sf.net/sfu/bobj-july</a> _______________________________________________ Opaltoolkit-users mailing list <a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Opa...@li...">Opa...@li...</a> <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://lists.sourceforge.net/lists/listinfo/opaltoolkit-users">https://lists.sourceforge.net/lists/listinfo/opaltoolkit-users</a> </pre> </blockquote> </div> ------------------------------------------------------------------------------<br> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day <br> trial. Simplify your report design, integration and deployment - and focus on <br> what you do best, core application coding. Discover what's new with <br> Crystal Reports now. <a moz-do-not-send="true" href="http://p.sf.net/sfu/bobj-july_______________________________________________">http://p.sf.net/sfu/bobj-july_______________________________________________</a><br> Opaltoolkit-users mailing list<br> <a moz-do-not-send="true" href="mailto:Opa...@li...">Opa...@li...</a><br> <a class="moz-txt-link-freetext" href="https://lists.sourceforge.net/lists/listinfo/opaltoolkit-users">https://lists.sourceforge.net/lists/listinfo/opaltoolkit-users</a><br> </blockquote> </div> <br> </div> </blockquote> </body> </html> |