#14 Attachment writing code (writeInputFile in edu.sdsc.nbcr.opal.AppServiceImpl) doesn't error check properly (patch included)

[James]

I had a problem where attachements set with the setAttachment method of InputFileType were not being copied to the working directory and no error messages were reported. On investigation I discovered that the reason my attachments weren't working was that I was uing a custom DataSource inside my DataHandler and the writeInputFile method in edu.sdsc.nbcr.opal.AppServiceImpl expects the getName method to return a path to a file. I assume that the DataHandler was expected to be wraping a FileDataSource.

The attached patch attempts to make the writeInputFile method more robust by adding error checking and allowing for a DataHandler that wraps things other then FileDataSource (via the DataHandler method writeTo). At the same time it will still do the efficent file rename for a wrapped FileDataSource but will use the getFile method of FileDataSource to access the underlying file instead of getName.

The patch can be applied to the current opal distribution with the commands:
cd opal-ws-2.5
patch -p1 -i ../PATH_TO_PATCH/opal_attachment.patch

[Luca Clementi]

Pulled you patch.

https://github.com/nbcrrolls/opaltoolkit/commit/0b933208795a24129944aad9066f2982618dfa9f

Clem