#72 fix config files

v4.0
closed
nobody
Bug fix (24)
5
2012-08-14
2008-11-13
No

Hello,
this is a patch for the autoconf files...

  1. patch

build_interpreter_platform_dir is defined nowhere, so I have removed it.
This avoids calling the compiler with "-I" ...

  1. patch

With gcc we need -pthread and not -mthreads

Bye
Rainer

Discussion

  • Rainer Tammer

    Rainer Tammer - 2008-11-13

    ooRexx-3684-V1.patch

     
  • Rainer Tammer

    Rainer Tammer - 2008-11-18

    ooRexx-3705-V1.patch

     
  • Rainer Tammer

    Rainer Tammer - 2008-11-18

    Hello,
    I have updated the patch for 3705.
    Bye
    Rainer

     
  • Rainer Tammer

    Rainer Tammer - 2008-11-20

    ooRexx-3715-V1.patch

     
  • Rainer Tammer

    Rainer Tammer - 2008-11-20

    Hello,

    unit test with 3715:

    Interpreter: REXX-ooRexx_4.0.0(MT) 6.03 20 Nov 2008
    ooRexxUnit: 2.0.0_3.2.0 ooTest: 1.0.0_4.0.0

    Tests ran: 18776
    Assertions: 551080
    Failures: 0
    Errors: 0
    Skipped files: 21

    File search: 00:00:11.301037
    Suite construction: 00:00:06.239305
    Test execution: 00:05:49.261144
    Total time: 00:06:11.298911

    unit test with 3705:

    ooTest Framework - Automated Test of the ooRexx Interpreter

    Interpreter: REXX-ooRexx_4.0.0(MT) 6.03 16 Nov 2008
    ooRexxUnit: 2.0.0_3.2.0 ooTest: 1.0.0_4.0.0

    Tests ran: 18776
    Assertions: 551080
    Failures: 0
    Errors: 0
    Skipped files: 21

    File search: 00:00:11.574041
    Suite construction: 00:00:06.395670
    Test execution: 00:04:13.695885
    Total time: 00:04:36.414776

    As you can notice the execution increased by 30%...

    Bye
    Rainer

     
  • Rainer Tammer

    Rainer Tammer - 2008-11-28

    Hello,
    3730 did not remedy the speed problem in AIX ...

    Interpreter: REXX-ooRexx_4.0.0(MT) 6.03 28 Nov 2008
    ooRexxUnit: 2.0.0_3.2.0 <----->ooTest: 1.0.0_4.0.0

    Tests ran: 18776
    Assertions: 551080
    Failures: 0
    Errors: 0
    Skipped files: 21

    File search: 00:00:11.179815
    Suite construction: 00:00:05.958706
    Test execution: 00:06:03.272067
    Total time: 00:06:25.252884

    I have doe a complete new build / install.
    No idea what happened...

    Bye
    Rainer Tammer

     
  • Rainer Tammer

    Rainer Tammer - 2008-12-06

    Hello,
    is there a problem with this patch ??
    Bye
    Rainer

     
  • Mark Miesfeld

    Mark Miesfeld - 2008-12-06

    Rainer,

    "is there a problem with this patch ??"

    I would suggest redoing your patch, by making it 2 patches. Separate out the SysSemaphore.hpp part and submit that patch separately. Attach a new patch here with just the configure.ac Makfile.am stuff. Then the two, unrelated, changes can each be considered on their own merits.

    Thanks.

     
  • Rainer Tammer

    Rainer Tammer - 2008-12-07

    ooRexx-3761-part1.patch

     
  • Rainer Tammer

    Rainer Tammer - 2008-12-07

    Hello,
    ooRexx-3761-part1.patch only contains the configure related patch.
    Bye
    Rainer

     
  • Rainer Tammer

    Rainer Tammer - 2008-12-17

    Hello,
    is there something wrong with ooRexx-3761-part1.patch ??

    Bye
    Rainer

     
  • Rick McGuire

    Rick McGuire - 2008-12-17

    If there was something wrong, you'd have heard about it by now. I suspect nobody's yet had the time look at integrating this (certainly my problem).

     
  • Rick McGuire

    Rick McGuire - 2008-12-17

    And, I should point out, you made the mistake of assigning this to me, so everybody else thinks I'm going to take care of it. Please leave patches unassigned when you open them.

     
  • Rick McGuire

    Rick McGuire - 2008-12-18

    Committed revision 3797.

     

Anonymous
Anonymous

Cancel  Add attachments