#67 ServiceException.hpp fix missing include, conversion warning

v4.0
closed
Bug fix (24)
5
2012-08-14
2008-10-12
No
  1. Add include for OpenBSD (4.3 and presumably prior and current).

  2. Remedy type conversion solecism pointed to by compile warning.

Discussion

  • Jack J. Woehr

    Jack J. Woehr - 2008-10-12

    unified diff

     
  • Rick McGuire

    Rick McGuire - 2008-10-12

    Joe, the why does the current code (which just uses 0 instead of NULL) still cause warnings? I'm not going to commit the change for that one. What part of this code requires sys\stat to be included? I'd like to see the warning that requires this, since I'm not convinced this header file is the most appropriate place for including that.

     
  • Jack J. Woehr

    Jack J. Woehr - 2008-10-12

    Without the #include patch (you can put it anywhere you want):

    g++ -DHAVE_CONFIG_H -I. -I. -I. -DORX_VER=4 -DORX_REL=0 -DORX_MOD=0 -DORX_FIX=0 -DORX_SYS_STR=\"NETBSD\" -DORX_CATDIR=\"/opt/ooRexx/bin\" -DORX_SHARED_LIBRARY_EXT=\".so\" -I./lib -I./api -I./api/platform/unix -I./rexxapi/client -I./rexxapi/client/platform/unix -I./rexxapi/common -I./rexxapi/common/platform/unix -I./common -I./common/platform/unix -g -O2 -g -O2 -DNOOPT -DPTHREAD_KERNEL -D_POSIX_THREAD -D_REENTRANT -D_GNU_SOURCE -DLINUX -DOPSYS_LINUX -MT librexxapi_la-LocalMacroSpaceManager.lo -MD -MP -MF .deps/librexxapi_la-LocalMacroSpaceManager.Tpo -c ./rexxapi/client/LocalMacroSpaceManager.cpp -fPIC -DPIC -o .libs/librexxapi_la-LocalMacroSpaceManager.o
    rexxapi/client/LocalMacroSpaceManager.cpp: In member function void MacroSpaceFile::create(long unsigned int)': rexxapi/client/LocalMacroSpaceManager.cpp:199: error:S_IRUSR' undeclared
    (first use this function)
    rexxapi/client/LocalMacroSpaceManager.cpp:199: error: (Each undeclared
    identifier is reported only once for each function it appears in.)
    rexxapi/client/LocalMacroSpaceManager.cpp:199: error: S_IRGRP' undeclared (first use this function) rexxapi/client/LocalMacroSpaceManager.cpp:199: error:S_IWUSR' undeclared
    (first use this function)
    rexxapi/client/LocalMacroSpaceManager.cpp:199: error: `S_IWGRP' undeclared
    (first use this function)
    *** Error code 1

    Stop in /usr/local/src/OORexx/sourceforge/trunk (line 3006 of Makefile).

    As far as the warnings for the type, it's up to you.

     
  • Rick McGuire

    Rick McGuire - 2008-10-12

    Applied to SysFile.hpp, which is where the constants that cause the error are defined.

     
  • Mark Miesfeld

    Mark Miesfeld - 2010-08-16

    This patch would have been in 4.0.0 or 4.0.1

     

Anonymous
Anonymous

Cancel  Add attachments