From: <mie...@us...> - 2011-01-05 00:24:14
|
Revision: 6550 http://oorexx.svn.sourceforge.net/oorexx/?rev=6550&view=rev Author: miesfeld Date: 2011-01-05 00:24:09 +0000 (Wed, 05 Jan 2011) Log Message: ----------- ooDialog - fix bug in fileOpenDialog Modified Paths: -------------- main/trunk/extensions/platform/windows/oodialog/oodRoutines.cpp Modified: main/trunk/extensions/platform/windows/oodialog/oodRoutines.cpp =================================================================== --- main/trunk/extensions/platform/windows/oodialog/oodRoutines.cpp 2011-01-05 00:21:55 UTC (rev 6549) +++ main/trunk/extensions/platform/windows/oodialog/oodRoutines.cpp 2011-01-05 00:24:09 UTC (rev 6550) @@ -444,7 +444,7 @@ } // Possible owner window. - if ( argumentExists(2) && !_hwndOwner != '\0' ) + if ( argumentExists(2) && *_hwndOwner != '\0' ) { OpenFileName.hwndOwner = (HWND)string2pointer(_hwndOwner); } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <mie...@us...> - 2011-02-17 00:38:58
|
Revision: 6773 http://oorexx.svn.sourceforge.net/oorexx/?rev=6773&view=rev Author: miesfeld Date: 2011-02-17 00:38:52 +0000 (Thu, 17 Feb 2011) Log Message: ----------- ooDialog - set the system error code for the MessageDialog routine Modified Paths: -------------- main/trunk/extensions/platform/windows/oodialog/oodRoutines.cpp Modified: main/trunk/extensions/platform/windows/oodialog/oodRoutines.cpp =================================================================== --- main/trunk/extensions/platform/windows/oodialog/oodRoutines.cpp 2011-02-17 00:36:19 UTC (rev 6772) +++ main/trunk/extensions/platform/windows/oodialog/oodRoutines.cpp 2011-02-17 00:38:52 UTC (rev 6773) @@ -169,10 +169,15 @@ * an owner window. If the user omits hwnd, then we try the to * find and use the topmost dialog. * + * + * @note Sets the .SystemErrorCode. + * */ RexxRoutine6(int, messageDialog_rtn, CSTRING, text, OPTIONAL_CSTRING, hwnd, OPTIONAL_CSTRING, _title, OPTIONAL_CSTRING, button, OPTIONAL_CSTRING, icon, OPTIONAL_CSTRING, miscStyles) { + oodResetSysErrCode(context->threadContext); + int result = -1; char *uprButton = NULL; @@ -251,6 +256,10 @@ } result = MessageBox(hwndOwner, text, title, flags); + if ( result == 0 ) + { + oodSetSysErrCode(context->threadContext); + } done_out: safeFree(uprButton); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <mie...@us...> - 2011-12-23 22:31:21
|
Revision: 7395 http://oorexx.svn.sourceforge.net/oorexx/?rev=7395&view=rev Author: miesfeld Date: 2011-12-23 22:31:15 +0000 (Fri, 23 Dec 2011) Log Message: ----------- ooDialog - fix FileNameDialog() so that the user is not stuck with .txt for the default file name extension. Modified Paths: -------------- main/trunk/extensions/platform/windows/oodialog/oodRoutines.cpp Modified: main/trunk/extensions/platform/windows/oodialog/oodRoutines.cpp =================================================================== --- main/trunk/extensions/platform/windows/oodialog/oodRoutines.cpp 2011-12-23 20:34:59 UTC (rev 7394) +++ main/trunk/extensions/platform/windows/oodialog/oodRoutines.cpp 2011-12-23 22:31:15 UTC (rev 7395) @@ -424,6 +424,12 @@ * * @return The selected file name(s) on success, 0 if the user cancelled or on * error. + * + * @remarks For the Default file extension. Previous to 4.2.0, .txt was + * always used unless the user specified something else. There is + * no way for the Rexx programmer to specify no extension. Now, if + * the argument is used, but the empty string the programmer can + * specify no extension. */ RexxRoutine8(RexxObjectPtr, fileNameDlg_rtn, OPTIONAL_CSTRING, preselected, OPTIONAL_CSTRING, _hwndOwner, OPTIONAL_RexxStringObject, fileFilter, @@ -530,7 +536,14 @@ } // Default file extension. - OpenFileName.lpstrDefExt = (argumentExists(6) && *_defExt != '\0') ? _defExt : "txt"; + if ( argumentExists(6) ) + { + OpenFileName.lpstrDefExt = *_defExt != '\0' ? _defExt : NULL; + } + else + { + OpenFileName.lpstrDefExt = "txt"; + } // Hook procedure to bring dialog to the foreground. OpenFileName.lpfnHook = OFNSetForegroundHookProc; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |