[Oorexx-bugs] [ oorexx-Bugs-2930620 ] Progress bar method setpos not working

[SourceForge.net <no...@so...>]

Bugs item #2930620, was opened at 2010-01-12 06:14
Message generated for change (Comment added) made by miesfeld
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=684730&aid=2930620&group_id=119701

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Interpreter
Group: v4.0
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: oorexxpert (oorexxpert)
Assigned to: Nobody/Anonymous (nobody)
Summary: Progress bar method setpos not working

Initial Comment:
Setpos in previous versions supported non-hole number for the setpos method.  In 4.0.0 a non-whole number generates message:

Error 88.907:  Argument 1 must be in the range -2147483648 to 2147483647; found ".5"

There is also to mention of whole numbers in the document.  Attached is testcase.  

I will have to back off 4.0.0 until fixed.

----------------------------------------------------------------------

>Comment By: Mark Miesfeld (miesfeld)
Date: 2010-01-14 08:53

Message:
John, 

(I'm thinking that oorexxpert is John R Bodoh, correct me if I'm wrong.)

There is a large range of issues here and rather than go deeply into them
in this bug report, it would be preferrable for you to start a conversation
on the ooRexx developer's list where it is likely that more people will
particpate.  If you don't start the conversation, I will this weekend.

Briefly some of the issues are:

* In fact this does not work on 3.2.0.  If you set the position to .5, the
position will not be .5

* The documentation for ooDialog is still mostly what IBM wrote.  The
ooDialog documentation as recieved from IBM was in many parts misleading,
incomplete, or flat out wrong.

* Except for a few rare cases, every number in ooDialog is a whole number.
 So, for the doc, I can see that a single blanket statement should be added
saying that unless explicitly documented otherwise, all numbers are whole
numbers.  But, where to put that in the doc.  Most people don't read the
doc that well anyway.  

In addition, going forward, this syntax condition is going to be raised
anywhere you are using non-whole numbers for arguments that are integers. 
For that reason, alone it would be good to discuss this on the developers
list and then later maybe on the RexxLA list.

* In older versions of ooDialog many times things did not work as expected
and the user had no clue as to why.  A large reason for this was the use of
incorrect arguments.  In many cases, the only way I could figure out what
was wrong was to laboriously trace through the source code.  Going forward
I intend to raise syntax conditions for incorrect arguments.  That way, I
can tell right away what is wrong.

* Finally, this issue opens up the very fundamental question: Prior to
ooRexx 4.0.0, ooDialog was mostly stuck at a Windows 3.0 level, certainly
stuck at Window 95.  The question is should it stay stuck at Windows 95, or
move forward to Windows 7.

----------------------------------------------------------------------

Comment By: oorexxpert (oorexxpert)
Date: 2010-01-14 04:47

Message:
Why does it work in 3.2?  I shouldn't have to access MSDN to know how to
code it in REXX.  If MSDN requires an integer, the OODREXX document should
say it has to be an integer.

Besides, the REXX i knew hid a lot of that operating system stuff and was
usually not so strict.  If it has to be an integer, REXX should handle
that...it can't make an integer from a REXX

----------------------------------------------------------------------

Comment By: Mark Miesfeld (miesfeld)
Date: 2010-01-13 20:28

Message:
You can only set the position of a progress bar to an integer value.  From
MSDN:

PBM_SETPOS Message

--------------------------------------------------------------------------------

Sets the current position for a progress bar and redraws the bar to
reflect the new position. 


Parameters

nNewPos
Signed integer that becomes the new position. 

In ooDialog, from 4.0.0 on, there is a much more rigorous check that
arguments to methods are correct.  When they are not correct, a syntax
condition will be raised.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=684730&aid=2930620&group_id=119701