[Oorexx-bugs] [ oorexx-Patches-2618794 ] UnInstaller deletes unrelated files

[SourceForge.net <no...@so...>]

Patches item #2618794, was opened at 2009-02-19 21:51
Message generated for change (Comment added) made by miesfeld
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=684732&aid=2618794&group_id=119701

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Brandon Cherry (bwcherry)
Assigned to: Nobody/Anonymous (nobody)
Summary: UnInstaller deletes unrelated files

Initial Comment:
RFE 1722389

----------------------------------------------------------------------

>Comment By: Mark Miesfeld (miesfeld)
Date: 2009-02-20 10:17

Message:
Brandon,

> It will be this evening before I could resolve this. 

That's okay, whenever you get a chance.

> I did not upgrade NSIS as the time (I guess I
> should have). 

Well, I haven't upgraded my NSIS for a long time either

> Basically, the way it deletes is from the bottom of the log 
> file up. The way it is suppose to work is if it cannot find 
> the log file it will default to the old behavior, but even
> then it is suppose to prompt you before it deletes.

Yeah, that part all works. It does delete from the bottom of
the log up.  It does revert, and prompt, to the old behavior
if I delete the log.

It looks like it is something that the uninstaller does after
all the files have been removed.


----------------------------------------------------------------------

Comment By: Brandon Cherry (bwcherry)
Date: 2009-02-20 10:04

Message:
It will be this evening before I could resolve this. I was using the same
machine to build (and test before submitting) as I did for 3.x (over a year
ago). I remember I had to update from Visual Studio 6 just to get it to
build on that machine again. I did not upgrade NSIS as the time (I guess I
should have). I will try to figure this out this evening.

Basically, the way it deletes is from the bottom of the log file up. The
way it is suppose to work is if it cannot find the log file it will default
to the old behavior, but even then it is suppose to prompt you before it
deletes.

----------------------------------------------------------------------

Comment By: Mark Miesfeld (miesfeld)
Date: 2009-02-20 09:45

Message:
Brandon,

Unfortunately, this doesn't work for me.  I'll try to take a closer look
over the weekend, but mayb you have some ideas.

I install, put a couple of extra files in the install directory. 
Uninstall log looks good.

Uninstall.  Whole directory is gone.

Now, on the second to last page of the uninstall, after it finishes
deleting all the files and says 'Completed' in the details area.  I look in
the files system.  At this point it is good, the ooRexx directory is still
there.  In the directory are the two files I added after install.  Also is
the uninstall.exe file.

I click next, so I'm on the last page. The file system still looks good. I
click 'Finish' everything is blown away.

I thought maybe you had left in the /r switch to the last RMDir, but no
you hadn't. 

The end of the uninstall section:

FileClose $uninstLog
Delete "$INSTDIR\${UninstLog}"
RMDir "INSTDIR"

When I looked at the file system and everything was good, the uninstall
log had already been deleted.  So, something happens when the Finish button
is clicked that blows everything away.

Any ideas?  What version of NSIS do you have.  Mine has MakeNSIS v2.19

Thanks.



----------------------------------------------------------------------

Comment By: Mark Miesfeld (miesfeld)
Date: 2009-02-20 05:35

Message:
Thanks Brandon.  I'll take a look at this sometime today.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=684732&aid=2618794&group_id=119701