#371 RFE 1754742 default methods need rework.

3.2.0
closed
Classes (182)
5
2012-08-14
2007-07-27
No

The refactoring introduced by RFE 1754742 is really backwards. The supplier method should not be an abstract method. The abstract methods should be allIndexes and allItems. Defining allItems by using supplier allItems is a very badly performing implementation. This would force many extra items to get created for some very fundamental operations, rending these default implementations essentially useless. On top of that, any implementation would need to produce the equivalent of allItems and allIndexes results just to implementent a supplier method in the first place.

Discussion

  • Rick McGuire

    Rick McGuire - 2007-07-27

    Logged In: YES
    user_id=1125291
    Originator: YES

    Committed revision 637.

     
  • Rick McGuire

    Rick McGuire - 2007-07-27

    Logged In: YES
    user_id=1125291
    Originator: YES

    David,

    Some more doc changes introduced by this. On the Collection class, the allItems and allIndexes methods are now abstract. Add the index method as an abstract method. The supplier method is no longer abstract.

     
  • David Ashley

    David Ashley - 2007-07-27

    Logged In: YES
    user_id=931756
    Originator: NO

    Docs fixed in revision 639.

     

Anonymous
Anonymous

Cancel  Add attachments