#355 ooDialog - symbolic IDs not always recognized

3.2.0
closed
5
2012-08-14
2007-06-24
No

The ooDialog doc, in the term definition section, reads:

id

The identification number of a dialog item. You assign an ID when you create the resource definition for your dialog. IDs 1, 2, and 9 are reserved for the OK, cancel, and Help push buttons. An ID can be either numerical (for example, 100) or symbolic (for example, "Bankaccount_Entry").

From that statement (An ID can be either numerical ... or symbolic,) and from the code itself, it is apparent that the original designers intended for numeric and symbolic resource IDs to be interchangable.

However, there are a number of places where this intention was not carried through.

I already fixed a couple of places. But, as I work with ooDialog, I keep stumbling across additional places. I'm opening this bug so I have something to refer to when I commit.

Discussion

  • Mark Miesfeld

    Mark Miesfeld - 2007-06-24

    Logged In: YES
    user_id=191588
    Originator: YES

    Committed revision 499

    This commit fixed the use of a symbolic ID for the resource ID of the dialog icon in the ResDlg class.

     
  • Mark Miesfeld

    Mark Miesfeld - 2007-06-24

    Logged In: YES
    user_id=191588
    Originator: YES

    Committed revision 502.

    In ooDialog, when creating an instance of a dialog, the user has the option of passing in a stem variable to set the initial state of dialog controls. If the user takes this option, the state of the controls when the dialog ends is copied back into the stem variable. Each index of the stem is the resource ID of a control, and the item at the index is the value (or state) with which to set the control (or the value of the control on return.)

    This commit allows symbolic IDs to be used as the indexes of the stem.

     
  • Mark Miesfeld

    Mark Miesfeld - 2007-07-21

    Logged In: YES
    user_id=191588
    Originator: YES

    Committed revision 611.

    This commit adds the check for a symbolic ID to the setMenu method of the ResDialog.

     
  • Mark Miesfeld

    Mark Miesfeld - 2007-09-23

    Logged In: YES
    user_id=191588
    Originator: YES

    I believe I've found and fixed the places where symbolic IDs were not recognized. Putting this into pending for the 3.2.0 release.

     


Anonymous

Cancel  Add attachments