#267 OODialog\'s \'dialog icon\' is dysfunctional

3.2.0
closed
5
2012-08-14
2007-05-15
No

The OODialog methods that run and display a dialog, like Execute, Popup, etc., have a parameter for the user to specify an icon resource:

" icon
The resource ID of the dialog’s icon."

There are a number of things broken related to this and I'm going to lump the fixes together under this bug.

1.) The code to load and set the dialog icon is missing a step that causes the dialog to hang at times.

2.) If the user does not specify an icon, the code intendes to load a default icon from oodialog.dll. We are not linking in the default icon, the .rc file is somewhat broken, and a few other minor problems releated to this.

3.) For an UserDialog, the code is attempting to pull an icon out of thin air.

Discussion

  • Mark Miesfeld

    Mark Miesfeld - 2007-05-30

    Logged In: YES
    user_id=191588
    Originator: YES

    Fixed in revision 417. I'm going to leave this in open until I update the ooDialog docs to reflect the changes.

     
  • Mark Miesfeld

    Mark Miesfeld - 2007-06-22

    Logged In: YES
    user_id=191588
    Originator: YES

    Committed revision 494.

    Revision 494 is a documentation commit that updates the ooDialog docs to reflect the changes introduced in fixing this bug.

    • The code was fixed to correctly set the dialog icon. The dialog icon is used in the Title Bar (caption bar,) the Task Bar, and the AltTab switching application. These icons now display correctly for ooDialog dialogs using icons loaded from a resouce only DLL, a resource script, or in a dynamic dialog added by the user.

    • Code was added to recognize an icon resource in a resource-only DLL and a resource script.

    • Code was added to load an icon resource dynamically so that a dialog icon could be used in a UserDialog.

    • A table for storing the user icons was added to the Admin table used by the C functions to manage ooDialog. A new method, addIcon, was added to the DynamicDialog class.

    • 4 icon resources are compiled and linked into oodialog.dll to give the user a choice of some pre-defined icons to use for their programs. Symbolic IDs were assigned for the icons and are made a part of the base dialog so that they are always available.

    • The docs were improved to try and better explain to the user how this all works.

     


Anonymous

Cancel  Add attachments





Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks