Menu

#1535 Request for a change in CMakeLists.txt

5.0.0
closed
nobody
None
none
1
2023-01-01
2018-04-03
No

Some time ago Enrico Sorichetti filed a CMakeLists that I am not sure was considered at the time.

Since then further amendments have been made to CMakeLists.txt but I have compared the CMakeLists.txt from todays build and I propose to replace lines 196-228 with lines 197-272 in Enricos version, that I have attached.

The changes relate to a Non-Windows section, and in particular to Apple/Mac builds.

I have extracted the relevant parts for comparison, please have a look and see if this change can be made.

The section in the current version emanate from a proposal of Alexander Adolf and aims at the same, namely to make the install Path relocatable at compile time. Without additional input the current CMakeLists.txt will create a build on <local User="">/Applications/ooRexx5.0.0 where it can hardly be used. Further the bin and the lib paths are both pointing to /bin in this default which is strange

3 Attachments

Related

Bugs: #1535

Discussion

  • Erich

    Erich - 2018-04-03

    Hi P. O.,
    please provide a patch.

    To do so, you can svn co the latest version, make changes to the version in you working copy, test it by building a current oorexx version and installing it. Check if it creates the expected installation, and – best case – have some or all from our Mac dev community (Adolf, Enrico, René, Rony) agree.

    Then svn diff >cmake-mac.patch and attach this patch here.

     
    • Per Olov Jonsson

      Ok, will do, thanks for providing instructions. I am still on a learning curve for these things ;-)

      BTW I will be away from 16:00 onwards so reply only tomorrow after that if I am not finishing today. Will go after Jenkins problem now.

      Hälsningar/Regards/Grüsse,
      P.O. Jonsson
      oorexx@jonases.se

      Am 03.04.2018 um 13:57 schrieb Erich erich_st@users.sourceforge.net:

      Hi P. O.,
      please provide a patch.

      To do so, you can svn co the latest version, make changes to the version in you working copy, test it by building a current oorexx version and installing it. Check if it creates the expected installation, and – best case – have some or all from our Mac dev community (Adolf, Enrico, René, Rony) agree.

      Then svn diff >cmake-mac.patch and attach this patch here.

      [bugs:#1535] https://sourceforge.net/p/oorexx/bugs/1535/ Request for a change in CMakeLists.txt

      Status: open
      Group: 5.0.0
      Created: Tue Apr 03, 2018 10:05 AM UTC by Per Olov Jonsson
      Last Updated: Tue Apr 03, 2018 10:05 AM UTC
      Owner: nobody
      Attachments:

      CMakeLists_Enrico.txt https://sourceforge.net/p/oorexx/bugs/1535/attachment/CMakeLists_Enrico.txt (113.2 kB; text/plain)
      excerpt_11401_2018-04-03.txt https://sourceforge.net/p/oorexx/bugs/1535/attachment/excerpt_11401_2018-04-03.txt (1.3 kB; text/plain)
      excerpt_Enrico.txt https://sourceforge.net/p/oorexx/bugs/1535/attachment/excerpt_Enrico.txt (1.6 kB; text/plain)
      Some time ago Enrico Sorichetti filed a CMakeLists that I am not sure was considered at the time.

      Since then further amendments have been made to CMakeLists.txt but I have compared the CMakeLists.txt from todays build and I propose to replace lines 196-228 with lines 197-272 in Enricos version, that I have attached.

      The changes relate to a Non-Windows section, and in particular to Apple/Mac builds.

      I have extracted the relevant parts for comparison, please have a look and see if this change can be made.

      The section in the current version emanate from a proposal of Alexander Adolf and aims at the same, namely to make the install Path relocatable at compile time. Without additional input the current CMakeLists.txt will create a build on <local User="">/Applications/ooRexx5.0.0 where it can hardly be used. Further the bin and the lib paths are both pointing to /bin in this default which is strange

      Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/oorexx/bugs/1535/ https://sourceforge.net/p/oorexx/bugs/1535/
      To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/ https://sourceforge.net/auth/subscriptions/

       

      Related

      Bugs: #1535

    • Per Olov Jonsson

      Dear Erich,

      I have amended CMakeLists.txt to reflect the changes proposed by Enrico so as to build to /usr/local/ooRexx5.0.0 by default

      There are further changes to show the settings before and after, this helps to see what is going on.

      The earlier default installed to /user/<current user="">/Applications/ooRexx5.0.0, this is problematic because it restricts the use of ooRexx to a single user on the machine.
      Also the proposed build put binaries in /bin and libraries in /lib. The earlier default build mixes binaries and libraries in /bin which is not very Unix-like.

      Feel free to propose further amendments to this CMakeLists.txt

      I have built a successful running installation using the following command:

      cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=RELEASE ../../oorexxsvn/oorexx-code-0

      And thereafter

      PATH="/usr/local/oorexx5.0.0/bin:/usr/local/oorexx5.0.0/lib:/usr/local/oorexx5.0.0/share:/usr/local/oorexx5.0.0/include:${PATH}“
      Export PATH

      Hälsningar/Regards/Grüsse,
      P.O. Jonsson
      oorexx@jonases.se

      Am 03.04.2018 um 13:57 schrieb Erich erich_st@users.sourceforge.net:

      Hi P. O.,
      please provide a patch.

      To do so, you can svn co the latest version, make changes to the version in you working copy, test it by building a current oorexx version and installing it. Check if it creates the expected installation, and – best case – have some or all from our Mac dev community (Adolf, Enrico, René, Rony) agree.

      Then svn diff >cmake-mac.patch and attach this patch here.

      [bugs:#1535] https://sourceforge.net/p/oorexx/bugs/1535/ Request for a change in CMakeLists.txt

      Status: open
      Group: 5.0.0
      Created: Tue Apr 03, 2018 10:05 AM UTC by Per Olov Jonsson
      Last Updated: Tue Apr 03, 2018 10:05 AM UTC
      Owner: nobody
      Attachments:

      CMakeLists_Enrico.txt https://sourceforge.net/p/oorexx/bugs/1535/attachment/CMakeLists_Enrico.txt (113.2 kB; text/plain)
      excerpt_11401_2018-04-03.txt https://sourceforge.net/p/oorexx/bugs/1535/attachment/excerpt_11401_2018-04-03.txt (1.3 kB; text/plain)
      excerpt_Enrico.txt https://sourceforge.net/p/oorexx/bugs/1535/attachment/excerpt_Enrico.txt (1.6 kB; text/plain)
      Some time ago Enrico Sorichetti filed a CMakeLists that I am not sure was considered at the time.

      Since then further amendments have been made to CMakeLists.txt but I have compared the CMakeLists.txt from todays build and I propose to replace lines 196-228 with lines 197-272 in Enricos version, that I have attached.

      The changes relate to a Non-Windows section, and in particular to Apple/Mac builds.

      I have extracted the relevant parts for comparison, please have a look and see if this change can be made.

      The section in the current version emanate from a proposal of Alexander Adolf and aims at the same, namely to make the install Path relocatable at compile time. Without additional input the current CMakeLists.txt will create a build on <local User="">/Applications/ooRexx5.0.0 where it can hardly be used. Further the bin and the lib paths are both pointing to /bin in this default which is strange

      Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/oorexx/bugs/1535/ https://sourceforge.net/p/oorexx/bugs/1535/
      To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/ https://sourceforge.net/auth/subscriptions/

       

      Related

      Bugs: #1535

  • Per Olov Jonsson

    Please put this request on hold, I have made further changes and will make another request later.

     
  • Erich

    Erich - 2018-12-26
    • status: open --> accepted
     
    • Per Olov Jonsson

      Dear Erich,

      I will go ahead and test in the coming days, on different machines.

      I propose to erase the build on the Mac mini (the content of ~/Applications) and make sure it is created clean, at the moment the /bin contain obsolete data (unless you cleaned it)

      Hälsningar/Regards/Grüsse,
      P.O. Jonsson
      oorexx@jonases.se

      Am 26.12.2018 um 16:02 schrieb Erich erich_st@users.sourceforge.net:

      status: open --> accepted
      Comment:
      Further the bin and the lib paths are both pointing to /bin in this default which is strange

      Committed revision 11646.
      This should fix the issue on macOS that the dylib's were written to bin instead of lib

      [bugs:#1535] https://sourceforge.net/p/oorexx/bugs/1535/ Request for a change in CMakeLists.txt

      Status: accepted
      Group: 5.0.0
      Created: Tue Apr 03, 2018 10:05 AM UTC by Per Olov Jonsson
      Last Updated: Tue Apr 10, 2018 11:51 AM UTC
      Owner: nobody
      Attachments:

      CMakeLists_Enrico.txt https://sourceforge.net/p/oorexx/bugs/1535/attachment/CMakeLists_Enrico.txt (113.2 kB; text/plain)
      excerpt_11401_2018-04-03.txt https://sourceforge.net/p/oorexx/bugs/1535/attachment/excerpt_11401_2018-04-03.txt (1.3 kB; text/plain)
      excerpt_Enrico.txt https://sourceforge.net/p/oorexx/bugs/1535/attachment/excerpt_Enrico.txt (1.6 kB; text/plain)
      Some time ago Enrico Sorichetti filed a CMakeLists that I am not sure was considered at the time.

      Since then further amendments have been made to CMakeLists.txt but I have compared the CMakeLists.txt from todays build and I propose to replace lines 196-228 with lines 197-272 in Enricos version, that I have attached.

      The changes relate to a Non-Windows section, and in particular to Apple/Mac builds.

      I have extracted the relevant parts for comparison, please have a look and see if this change can be made.

      The section in the current version emanate from a proposal of Alexander Adolf and aims at the same, namely to make the install Path relocatable at compile time. Without additional input the current CMakeLists.txt will create a build on <local user="">/Applications/ooRexx5.0.0 where it can hardly be used. Further the bin and the lib paths are both pointing to /bin in this default which is strange</local>

      Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/oorexx/bugs/1535/ https://sourceforge.net/p/oorexx/bugs/1535/
      To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/ https://sourceforge.net/auth/subscriptions/

       

      Related

      Bugs: #1535

  • Erich

    Erich - 2018-12-26

    Further the bin and the lib paths are both pointing to /bin in this default which is strange

    Committed revision 11646.
    This should fix the issue on macOS that the dylib's were written to bin instead of lib

     
  • Erich

    Erich - 2018-12-27

    Hi, P.O.
    I had removed Applications/ooRexx5.0.0 a few times to test the fix, but don't hesitate and test too

     
  • Erich

    Erich - 2019-01-18
    • status: accepted --> pending
     
  • Rony G. Flatscher

    • Status: pending --> closed
     

Anonymous
Anonymous

Add attachments
Cancel