Menu

#20 Many variables don't get accessed correctly.

open
nobody
None
5
2005-05-13
2005-05-13
Anonymous
No

I don't know if this is an issue with later versions of php
and this program, but I'm guessing a default (like
register_globals) has changed and completely broken
this script.

To fix some of the issues you can add this to the long
string of conditionals in the beggining of the script:

if (isset($_REQUEST['filename'] )) { $filename =
$_REQUEST['filename']; }
else { $filename = ""; }
if (isset($_REQUEST['edit'] )) { $edit = $_REQUEST
['edit']; }
else { $edit = ""; }
if (isset($_REQUEST['cpmv'] )) { $cpmv =
$_REQUEST['cpmv']; }
else { $cpmv = ""; }
if (isset($_REQUEST['save'] )) { $save = $_REQUEST
['save']; }
else { $save = ""; }
if (isset($_REQUEST['savefile'] )) { $savefile =
$_REQUEST['savefile']; }
else { $savefile = ""; }
if (isset($_REQUEST['newcontent'] )) { $newcontent =
$_REQUEST['newcontent']; }
else { $newcontent = ""; }

I haven't finished testing, and some things are still
broken, but I'm sure this is the right track.

In the next release it would be wise to access all
$_REQUEST data directly.

Discussion


Log in to post a comment.

MongoDB Logo MongoDB