#98 macro expansion bug (infinite loop)

[Lincoln Ramsay]

I wrote this innocuous-looking code...

UInt32 ref;
UInt32 time;
// set ref and time
AlmSetProcAlarm(MyFunc, ref, time);

This causes a hang. It turns out it's an infinite loop.

The problem is that the AlmSetProcAlarm macro uses 'ref' as the second argument. There is a check in the code to handle 'recursive' arguments like this but since I put a space after the comma, this code was foiled.

I have a work around for this (skip over any white space before doing the recursive check) that seems to work fine (both in POSE and onboard).

I've put up a binary for testing at the usual location.
http://ramsay.webhop.org/OnBoard.zip

[Steve Little]

Logged In: YES
user_id=583634
Originator: NO

This sounds suspiciously like this bug:
https://sourceforge.net/tracker/index.php?func=detail&aid=652833&group_id=55794&atid=500573

#652833

Link - Can you check if your patch fixes this one as well?

Thanks again for fixing this one!

[Nobody/Anonymous]

Logged In: NO

The fix for this bug does not fix bug 652833. It looks similar though, certainly the same area in the code so I'll take a look at it too (since I'm now kind-of familiar with the macro code).

[Lincoln Ramsay]

Logged In: YES
user_id=736434
Originator: YES

This has been fixed in CVS.