omniprint-developer

Re: [Omniprint-developer] Omni 0.7.3 foomatic data broken

[Mark H. <ha...@us...>]

Hi Tim,

There was a problem in the new IBM drivers that didn't translate strings
properly.
This has been fixed in the latest CVS code.

I just noticed that RH 9.0 is shipping soon.  Is it too late to get a new
package into the CD?  I have realized that the CUPS support was accidently
disabled in the CUPS filter.

Mark

Take a look at the Linux Omni Printer Driver Framework at
http://www.ibm.com/linux/ltc/projects/omni/

Re: [Omniprint-developer] Omni 0.7.3 foomatic data broken

[Mark H. <ha...@us...>]

> Care to give me a pointer?  Here's the fix I'm using in rawhide:

The IBM Instances were the ones that were fixed, IIRC.  These were:
      IBM Pages Instance.[hc]pp
      IBM 5577 Instance.[hc]pp

Unfortunately, three other global fixes and code clean up occured as well.
So you can't just take the current code.

They are missing translateKeyValue () functions (and listKeyValues () as
well).

Mark

Take a look at the Linux Omni Printer Driver Framework at
http://www.ibm.com/linux/ltc/projects/omni/

Re: [Omniprint-developer] Omni 0.7.3 foomatic data broken

[Tim W. <tw...@re...>]

On Tue, Mar 25, 2003 at 01:58:56PM -0600, Mark Hamzy wrote:

> There was a problem in the new IBM drivers that didn't translate strings
> properly.
> This has been fixed in the latest CVS code.

Care to give me a pointer?  Here's the fix I'm using in rawhide:

--- Omni/Foomatic/OmniFoomaticGenerator.cpp.ofg	2003-03-24 13:14:44.000000000 +0000
+++ Omni/Foomatic/OmniFoomaticGenerator.cpp	2003-03-24 13:15:11.000000000 +0000
@@ -2112,6 +2112,9 @@
         pszKey  = (char *)next->first.c_str ();
         pDevice = next->second;
 
+        string *pRet = pDevice->translateKeyValue (pszKey, 0);
+        if (!pRet) continue;
+
         cout << argv[0] << ": Extra Options: " << pszKey << endl;
 
         oss.str ("");
@@ -2142,8 +2145,6 @@
 
 ////////cout << "Trying " << pDevice->getDriverName () << "." << pDevice->getDeviceName () << endl;
 
-        string *pRet = pDevice->translateKeyValue (pszKey, 0);
-
         *pofstream << "   <en>" << *pRet << "</en>" << endl;
 
         delete pRet;

Tim.
*/