Re: [Omniprint-developer] Omni 0.7.3 foomatic data broken

[Tim W. <tw...@re...>]

On Tue, Mar 25, 2003 at 01:58:56PM -0600, Mark Hamzy wrote:

> There was a problem in the new IBM drivers that didn't translate strings
> properly.
> This has been fixed in the latest CVS code.

Care to give me a pointer?  Here's the fix I'm using in rawhide:

--- Omni/Foomatic/OmniFoomaticGenerator.cpp.ofg	2003-03-24 13:14:44.000000000 +0000
+++ Omni/Foomatic/OmniFoomaticGenerator.cpp	2003-03-24 13:15:11.000000000 +0000
@@ -2112,6 +2112,9 @@
         pszKey  = (char *)next->first.c_str ();
         pDevice = next->second;
 
+        string *pRet = pDevice->translateKeyValue (pszKey, 0);
+        if (!pRet) continue;
+
         cout << argv[0] << ": Extra Options: " << pszKey << endl;
 
         oss.str ("");
@@ -2142,8 +2145,6 @@
 
 ////////cout << "Trying " << pDevice->getDriverName () << "." << pDevice->getDeviceName () << endl;
 
-        string *pRet = pDevice->translateKeyValue (pszKey, 0);
-
         *pofstream << "   <en>" << *pRet << "</en>" << endl;
 
         delete pRet;

Tim.
*/