Menu

#63 Makefile checks kernel sublevel only

Current release
open
nobody
None
5
2013-06-16
2013-06-16
Efreak
No

Lines 126-136, specifically line 129 is incorrect.
As seen in the comment on the line above it, line 129 is intended to check if the kernel is newer than 2.6.16. Unfortunately, it neglects to check the full kernel version, and only checks the sublevel. I'm surprised this wasn't noticed when 3.0 came out 2 years ago.

126 ifeq ($(OMNIBOOK_WANT_BACKLIGHT),y)
127 ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
128 # we support backlight interface only after 2.6.16
129 ifeq ($(shell if [ $(SUBLEVEL) -gt 16 ] ; then echo -n 'y'; fi),y)
130 EXTRA_CFLAGS += -DCONFIG_OMNIBOOK_BACKLIGHT
131 else
132 $(warning "Backlight support in only supported for kernel version newer than 2.6.16")
133 $(warning "Disabling backlight sysfs interface")
134 endif
135 endif
136 endif

Discussion


Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.