#10 Should be fixed for kernel 2.6.17

[Julien Valroff]

Hi,

omnibook kernel module is not ready for 2.6.17.

First thing, MODULE_PARM cannot be used any more and
has to be replaced by module_param. This can be done
easily with the attached patch.

Also, I cannot load the module because of two unknown
symbols: pm_unregister and isa_memcpy_fromio
I am not a kernel guru but I have seen that
pm_(un)register have been deprecated for a quite long
time now, and unused isa_* helpers were removed from
the kernel.

There are also a lot of warnings when compiling:
/home/julien/kernel/modules/omnibook/touchpad.c: At top
level:
/home/julien/kernel/modules/omnibook/touchpad.c:47:
warning: ‘proc_touchpad’ defined but not used
/home/julien/kernel/modules/omnibook/touchpad.c:69:
warning: ‘omnibook_touchpad_on’ defined but not used
/home/julien/kernel/modules/omnibook/touchpad.c:102:
warning: ‘omnibook_touchpad_register’ defined but not used
/home/julien/kernel/modules/omnibook/touchpad.c:109:
warning: ‘omnibook_touchpad_unregister’ defined but not
used
/home/julien/kernel/modules/omnibook/touchpad.c:172:
warning: ‘omnibook_touchpad_status’ defined but not used
/home/julien/kernel/modules/omnibook/touchpad.c:181:
warning: ‘omnibook_touchpad_set’ defined but not used

Please fix these issues in a new release, as they make
the omnibook module ununsable with latest linux kernels.

Cheers,
Julien

[Julien Valroff]

Replaces MODULE_PARM calls by module_param in init.c

[treym]

Logged In: YES
user_id=1546014

kernel 2.6.17-gentoo, this work for me :

--- omnibook-20060126/onetouch.c 2006-01-25
18:46:45.000000000 +0100
+++ omnibook-20060626/onetouch.c 2006-06-26
06:03:20.000000000 +0200
@@ -95,7 +95,7 @@

static void omnibook_onetouch_unregister(void)
{
- pm_unregister(pm_onetouch);
+ pm_unregister_all(pm_onetouch_callback);
pm_onetouch_callback = NULL;
}

and :

--- omnibook-20060126/touchpad.c 2006-01-25
18:46:54.000000000 +0100
+++ omnibook-20060626/touchpad.c 2006-06-26
06:02:39.000000000 +0200
@@ -108,7 +108,7 @@
static void omnibook_touchpad_unregister(void)
{
pm_touchpad_callback = NULL;
- pm_unregister(pm_touchpad);
+ pm_unregister_all(pm_touchpad_callback);
}

[Julien Valroff]

Logged In: YES
user_id=464661

Hi,

Thanks for this, I will try tonight.

What about the isa_memcpy_fromio symbols? Don't you have
any problems with them?

Cheers,
Julien

[treym]

Logged In: YES
user_id=1546014

isa_memcpy_fromio was allready fix for me :
i'm using portage,
http://mir2.ovh.net/gentoo-portage/app-laptop/omnibook/ChangeLog\).

this should work :

Patch to fix compile and load problem.
Caused by a cleanup:
http://lkml.org/lkml/2006/1/26/327

--- omnibook-20060126/dmi.c 2003-09-29
11:50:34.000000000 +0200
+++ omnibook-20060126/dmi.c 2006-03-02
02:00:39.000000000 +0100
@@ -128,7 +128,9 @@

while( fp < 0xFFFFF)
{
- isa_memcpy_fromio(buf, fp, 15);
+ void __iomem *addr = ioremap(fp, 15);
+ memcpy_fromio(buf, addr, 15);
+ iounmap(addr);
if(memcmp(buf, "_DMI_", 5)==0 &&
dmi_checksum(buf))
{
u16 num=buf[13]<<8|buf[12];

[Kelly Price]

Logged In: YES
user_id=19363

Warning: The posted patches below (the ones not attached)
need reformatting if you copy/paste them.

I'll attach a roundup patch after I do a manual compile.

[Nobody/Anonymous]

Logged In: NO

This patch not work...!
I applied on the omnibook-20060126, compile, install, but,
when i use modprobe omnibook or modprobe omnibook ectype=1,
the error persist:

FATAL: Error inserting omnibook
(/lib/modules/2.6.17-suspend2-r2/char/omnibook.ko): Unknown
symbol in module, or unknown parameter (see dmesg)

on dmesg
omnibook: Unknown symbol pm_unregister

You have any patch to correct this error?

Tanks!

Lopan (lopan.eti[@]gmail.com)

[Darren Salt]

Logged In: YES
user_id=294680

Works for me, but note bug 1551623.

[Kelly Price]

Logged In: YES
user_id=19363

There seems to be an updated patch on a different project,
the "omnibook" project here on SF, that is working.

[Nobody/Anonymous]

Logged In: NO

try the new project http://sourceforge.net/projects/omnibook/

- Modules working with 2.6.17+
- works with wmtemp from this project here