[ojAlgo-user] new to sf

[Nick W. <nw...@us...>]

Hey,
I'm new to Sourceforge and this mailing list.  I read in the version 19 post
that major changes are coming in the next version.  I had some small
recommendations that may cause significant changes downstream on any
dependent classes.  I wasn't sure if I should just make my check out with
version 19 or wait till version 20.


>From quickly looking at the classes, I saw in the PrimitiveDenseStore the
PhysicalFactory static nested class and it's makeCopy methods.  I would
recommend not overriding the methods and instead have three methods that are
defined by their name and not just the parameters.  Since the parameters are
just interfaces and it's possible that a class may implement more than one
of the interfaces, no matter how illogical, it might be better to have them
be separate method names, say, makeBasicMatrix and makeMatrixStore.

Perhaps this will be changed with version 20.  Anyway, my math skills aren't
fantastic, but I'm interested in this project and I'd like to help out.  I'm
open to advice and critiques as well.  I hope that this will be a good Open
Source experience (my first).

Nick