Sorry it took me longer to get to this than I expected; I looked at the restructuring of the directories in
svn.code.sf.net/p/ohnlp/code/branches/source-directory-reorg/MedTagger/
Overall, it looks great - but I do have a few comments
My personal preference is to have the scripts that are used to start the program at the root directory instead of inside a directory called scripts. Maybe we should ask Hongfang to voice her opinion on that.
Secondly, I think it is a good idea to have the (empty) bin directory in svn so that if an Eclipse user has auto-build turned off, when they check out the project in Eclipse, they don't get an error about the bin directory missing.
The README lists the directories and their meanings. It would be great if you could update that.
I think it would be better not to have .gradle marked as svn:ignore so that if we do try again to have a .gradle someday it doesn't cause confusion. I try not to check in svn:ignore for things that someone else might try to create (commonly used names)
-- James
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Will,
picking up from our discussion we had started as comments on the https://sourceforge.net/p/ohnlp/wiki/OHNLP/ page:
Sorry it took me longer to get to this than I expected; I looked at the restructuring of the directories in
svn.code.sf.net/p/ohnlp/code/branches/source-directory-reorg/MedTagger/
Overall, it looks great - but I do have a few comments
My personal preference is to have the scripts that are used to start the program at the root directory instead of inside a directory called scripts. Maybe we should ask Hongfang to voice her opinion on that.
Secondly, I think it is a good idea to have the (empty) bin directory in svn so that if an Eclipse user has auto-build turned off, when they check out the project in Eclipse, they don't get an error about the bin directory missing.
The README lists the directories and their meanings. It would be great if you could update that.
I think it would be better not to have .gradle marked as svn:ignore so that if we do try again to have a .gradle someday it doesn't cause confusion. I try not to check in svn:ignore for things that someone else might try to create (commonly used names)
-- James