Menu

#1386 Added "compile_arguments" support for GLSLESCgProgram

Azathoth
open
5
2012-12-15
2012-03-27
oiram
No

Discussion

  • oiram

    oiram - 2012-03-27

    Added "compile_arguments" support for GLSLESCgProgram

     
  • Holger Frydrych

    Holger Frydrych - 2012-07-22
    • assigned_to: nobody --> masterfalcon
     
  • David Rogers

    David Rogers - 2012-08-19

    Thanks for your patch. However, according to our records we do not appear to have received a Contributor License Agreement from you yet, which means we cannot accept your code into the core yet.

    In order for us to accept your contribution, please can you submit a contributor agreement as discussed in this page: http://www.ogre3d.org/developers/submit-patch .

    Thanks!

     
  • oiram

    oiram - 2012-08-31

    I've submit a contributor agreement, please check it.

     
  • David Rogers

    David Rogers - 2012-12-15

    Please resolve these errors and resubmit the patch. Thanks

    /Users/davidrogers/Documents/Development/Ogre/ogre-v1-8/RenderSystems/GLES2/src/GLSLES/src/OgreGLSLESCgProgram.cpp:375:16: warning: declaration shadows a local variable [-Wshadow]
    String sourceToUse = resolveCgIncludes(mSource, this, mFilename);
    ^
    /Users/davidrogers/Documents/Development/Ogre/ogre-v1-8/RenderSystems/GLES2/src/GLSLES/src/OgreGLSLESCgProgram.cpp:372:16: note: previous declaration is here
    String sourceToUse = resolveCgCompileArguments(mSource);
    ^
    /Users/davidrogers/Documents/Development/Ogre/ogre-v1-8/RenderSystems/GLES2/src/GLSLES/src/OgreGLSLESCgProgram.cpp:375:16: error: redefinition of 'sourceToUse'
    String sourceToUse = resolveCgIncludes(mSource, this, mFilename);
    ^
    /Users/davidrogers/Documents/Development/Ogre/ogre-v1-8/RenderSystems/GLES2/src/GLSLES/src/OgreGLSLESCgProgram.cpp:372:16: note: previous definition is here
    String sourceToUse = resolveCgCompileArguments(mSource);
    ^
    /Users/davidrogers/Documents/Development/Ogre/ogre-v1-8/RenderSystems/GLES2/src/GLSLES/src/OgreGLSLESCgProgram.cpp:510:61: error: no member named 'getCompileArguments' in 'Ogre::GLSLESCgProgram'
    return static_cast<const GLSLESCgProgram*="">(target)->getCompileArguments();
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
    /Users/davidrogers/Documents/Development/Ogre/ogre-v1-8/RenderSystems/GLES2/src/GLSLES/src/OgreGLSLESCgProgram.cpp:514:48: error: no member named 'setCompileArguments' in 'Ogre::GLSLESCgProgram'
    static_cast<GLSLESCgProgram*>(target)->setCompileArguments(val);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
    1 warning and 3 errors generated.

     
  • David Rogers

    David Rogers - 2012-12-15
    • milestone: --> Azathoth
     

Log in to post a comment.