#1326 Fixes incorrect ZipArchive behaviour

Byatis
open-wont-fix
nobody
bugfix (702)
5
2012-11-25
2011-06-23
Anonymous
No

ZipArchive will use the basename as the filename, which is incorrect as per the API documentation for FileInfo. This will in some cases cause recursive loading of materials to fail, since find will return the basename as the filename, which will lead to the open call failing in case more than one file with the same basename exist in the archive.

The attached patch demonstrates a fix to the issue. The unit tests were run with the attached patch applied and passed successfully.

Discussion

  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2011-06-23

    Fixes incorrect deduction of the filename through the basename.

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2011-06-23

    PS: Since the removal of three lines of code is not a creative work, no copyright assignment is necessary.

     
  • David Rogers

    David Rogers - 2011-06-28
    • status: open --> closed
     
  • David Rogers

    David Rogers - 2011-06-28

    Reopening due to a bug found.

     
  • David Rogers

    David Rogers - 2011-06-28
    • status: closed --> open
     
  • Murat Sari

    Murat Sari - 2012-11-25

    This patch breaks the loading of file which are contained in subfolders - before ogre could not parse material files (programs etc).

     
  • Murat Sari

    Murat Sari - 2012-11-25
    • status: open --> open-wont-fix
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks