Menu
▾
▴
#12 format security
drgeo_postscriptdrawable.cc:133:52: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf (fileHandle, postscriptColor[style.color]);
^
drgeo_postscriptdrawable.cc:134:69: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf (fileHandle, postscriptLineWidth[drgeoThicknessNormal + 1]);
^
drgeo_postscriptdrawable.cc: In member function 'virtual void drgeoPostScriptDrawable::drawPolygon(drgeoStyle&, drgeoVector, gint)':
drgeo_postscriptdrawable.cc:210:52: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf (fileHandle, postscriptColor[style.color]);
^
drgeo_postscriptdrawable.cc:212:46: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf (fileHandle, postscriptLineWidth[0]);
^
drgeo_postscriptdrawable.cc: In member function 'virtual void drgeoPostScriptDrawable::drawSegment(drgeoStyle&, drgeoVector&, drgeoVector&)':
drgeo_postscriptdrawable.cc:238:52: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf (fileHandle, postscriptColor[style.color]);
^
drgeo_postscriptdrawable.cc:240:48: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf (fileHandle, postscriptLineWidth[0]);
^
drgeo_postscriptdrawable.cc:242:62: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf (fileHandle, postscriptLineWidth[style.thick + 1]);
^
drgeo_postscriptdrawable.cc: In member function 'virtual void drgeoPostScriptDrawable::drawCircle(drgeoStyle&, drgeoVector&, double)':
drgeo_postscriptdrawable.cc:266:52: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf (fileHandle, postscriptColor[style.color]);
^
drgeo_postscriptdrawable.cc:268:48: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf (fileHandle, postscriptLineWidth[0]);
^
drgeo_postscriptdrawable.cc:270:62: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf (fileHandle, postscriptLineWidth[style.thick + 1]);
^
drgeo_postscriptdrawable.cc: In member function 'virtual void drgeoPostScriptDrawable::drawArc(drgeoStyle&, drgeoVector&, double, double, double)':
drgeo_postscriptdrawable.cc:288:52: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf (fileHandle, postscriptColor[style.color]);
^
drgeo_postscriptdrawable.cc:290:48: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf (fileHandle, postscriptLineWidth[0]);
^
drgeo_postscriptdrawable.cc:292:62: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf (fileHandle, postscriptLineWidth[style.thick + 1]);
^
drgeo_postscriptdrawable.cc: In member function 'virtual void drgeoPostScriptDrawable::drawText(drgeoVector&, char, drgeoColorType)':
drgeo_postscriptdrawable.cc:339:50: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf (fileHandle, postscriptColor[fontColor]);
^
cc1plus: some warnings being treated as errors
Makefile:433: recipe for target 'drgeo_postscriptdrawable.o' failed
make[3]: *** [drgeo_postscriptdrawable.o] Error 1
make[3]: Leaving directory '/home/user/rpmbuild/drgeo/BUILD/drgeo-1.1.0/geo'
make[3]: *** Waiting for unfinished jobs....
make[3]: Entering directory '/home/user/rpmbuild/drgeo/BUILD/drgeo-1.1.0/geo'
if g++ -DHAVE_CONFIG_H -I. -I. -I.. -DGNOMELOCALEDIR=\""/usr/share/locale"\" -DLOCALEDIR=\"/usr/share/locale\" -DLIBRARY_DIR=\""/usr/share/geo/"\" -DDRGEO_HELPDIR=\""/usr/share/drgeo/help"\" -DDRGEO_GLADEDIR=\""/usr/share/drgeo/glade"\" -DDRGEO_ENCODEDIR=\""/usr/share/drgeo/encode"\" -I/usr/include -D_REENTRANT -pthread -I/usr/include/libglade-2.0 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/directfb -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libxml2 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libxml2 -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fomit-frame-pointer -march=i586 -mtune=generic -fasynchronous-unwind-tables -MT drgeo_drawable.o -MD -MP -MF ".deps/drgeo_drawable.Tpo" \
-c -o drgeo_drawable.o test -f 'drgeo_drawable.cc' || echo './'drgeo_drawable.cc; \
then mv -f ".deps/drgeo_drawable.Tpo" ".deps/drgeo_drawable.Po"; \
else rm -f ".deps/drgeo_drawable.Tpo"; exit 1; \
fi
make[3]: Leaving directory '/home/user/rpmbuild/drgeo/BUILD/drgeo-1.1.0/geo'
make[3]: Entering directory '/home/user/rpmbuild/drgeo/BUILD/drgeo-1.1.0/geo'
if g++ -DHAVE_CONFIG_H -I. -I. -I.. -DGNOMELOCALEDIR=\""/usr/share/locale"\" -DLOCALEDIR=\"/usr/share/locale\" -DLIBRARY_DIR=\""/usr/share/geo/"\" -DDRGEO_HELPDIR=\""/usr/share/drgeo/help"\" -DDRGEO_GLADEDIR=\""/usr/share/drgeo/glade"\" -DDRGEO_ENCODEDIR=\""/usr/share/drgeo/encode"\" -I/usr/include -D_REENTRANT -pthread -I/usr/include/libglade-2.0 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/directfb -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libxml2 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libxml2 -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fomit-frame-pointer -march=i586 -mtune=generic -fasynchronous-unwind-tables -MT drgeo_gtkdrawable.o -MD -MP -MF ".deps/drgeo_gtkdrawable.Tpo" \
-c -o drgeo_gtkdrawable.o test -f 'drgeo_gtkdrawable.cc' || echo './'drgeo_gtkdrawable.cc; \
then mv -f ".deps/drgeo_gtkdrawable.Tpo" ".deps/drgeo_gtkdrawable.Po"; \
else rm -f ".deps/drgeo_gtkdrawable.Tpo"; exit 1; \
fi
make[3]: Leaving directory '/home/user/rpmbuild/drgeo/BUILD/drgeo-1.1.0/geo'
make[3]: Entering directory '/home/user/rpmbuild/drgeo/BUILD/drgeo-1.1.0/geo'
if g++ -DHAVE_CONFIG_H -I. -I. -I.. -DGNOMELOCALEDIR=\""/usr/share/locale"\" -DLOCALEDIR=\"/usr/share/locale\" -DLIBRARY_DIR=\""/usr/share/geo/"\" -DDRGEO_HELPDIR=\""/usr/share/drgeo/help"\" -DDRGEO_GLADEDIR=\""/usr/share/drgeo/glade"\" -DDRGEO_ENCODEDIR=\""/usr/share/drgeo/encode"\" -I/usr/include -D_REENTRANT -pthread -I/usr/include/libglade-2.0 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/directfb -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libxml2 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libxml2 -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fomit-frame-pointer -march=i586 -mtune=generic -fasynchronous-unwind-tables -MT drgeo_flydrawable.o -MD -MP -MF ".deps/drgeo_flydrawable.Tpo" \
-c -o drgeo_flydrawable.o test -f 'drgeo_flydrawable.cc' || echo './'drgeo_flydrawable.cc; \
then mv -f ".deps/drgeo_flydrawable.Tpo" ".deps/drgeo_flydrawable.Po"; \
else rm -f ".deps/drgeo_flydrawable.Tpo"; exit 1; \
fi
drgeo_flydrawable.cc:32:19: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
{ "3", "5", "7" };
^
drgeo_flydrawable.cc:32:19: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:32:19: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:35:29: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
{ "dline", "line", "line" };
^
drgeo_flydrawable.cc:35:29: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:35:29: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:38:24: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
{ "0", "1", "1", "2" };
^
drgeo_flydrawable.cc:38:24: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:38:24: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:38:24: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:44:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
};
^
drgeo_flydrawable.cc:44:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:44:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:44:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:44:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:44:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:44:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:44:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:44:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:44:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:44:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:44:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:50:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
};
^
drgeo_flydrawable.cc:50:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:50:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:50:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:50:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:50:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:50:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:50:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:50:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:50:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:50:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc:50:1: warning: deprecated conversion from string constant to 'gchar {aka char}' [-Wwrite-strings]
drgeo_flydrawable.cc: In member function 'virtual void drgeoFlyDrawable::drawSegment(drgeoStyle&, drgeoVector&, drgeoVector&)':
drgeo_flydrawable.cc:194:10: warning: deprecated conversion from string constant to 'char' [-Wwrite-strings]
command = "line";
^
drgeo_flydrawable.cc:200:50: warning: format '%d' expects argument of type 'int', but argument 3 has type 'char' [-Wformat=]
fprintf (fileHandle, "linewidth %d\n", thickness);
^
drgeo_flydrawable.cc:207:75: warning: format '%d' expects argument of type 'int', but argument 3 has type 'gchar {aka char}' [-Wformat=]
fprintf (fileHandle, "linewidth %d\n", flyLineWidth[drgeoThicknessNormal]);
^
drgeo_flydrawable.cc: In member function 'virtual void drgeoFlyDrawable::drawCircle(drgeoStyle&, drgeoVector&, double)':
drgeo_flydrawable.cc:233:50: warning: format '%d' expects argument of type 'int', but argument 3 has type 'char' [-Wformat=]
fprintf (fileHandle, "linewidth %d\n", thickness);
^
drgeo_flydrawable.cc:239:75: warning: format '%d' expects argument of type 'int', but argument 3 has type 'gchar {aka char}' [-Wformat=]
fprintf (fileHandle, "linewidth %d\n", flyLineWidth[drgeoThicknessNormal]);
^
drgeo_flydrawable.cc: In member function 'virtual void drgeoFlyDrawable::drawArc(drgeoStyle&, drgeoVector&, double, double, double)':
drgeo_flydrawable.cc:257:50: warning: format '%d' expects argument of type 'int', but argument 3 has type 'char' [-Wformat=]
fprintf (fileHandle, "linewidth %d\n", thickness);
^
drgeo_flydrawable.cc:272:75: warning: format '%d' expects argument of type 'int', but argument 3 has type 'gchar {aka char}' [-Wformat=]
fprintf (fileHandle, "linewidth %d\n", flyLineWidth[drgeoThicknessNormal]);
^
make[3]: Leaving directory '/home/user/rpmbuild/drgeo/BUILD/drgeo-1.1.0/geo'
Makefile:482: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1
Makefile:460: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
Makefile:304: recipe for target 'all' failed
make: *** [all] Error 2
Patch with fix: