#58 fem-fenics-0.0.1

None
closed
nobody
None
1
2017-02-17
2013-09-09
Marco
No

Discussion

  • Marco

    Marco - 2013-09-09
    • Group: -->
     
  • Marco

    Marco - 2013-09-09
     
  • Carnë Draug

    Carnë Draug - 2013-09-11

    Some fixes:

    • if package is named fem-fenics then must be in directory named fem-fenics (it is named fem)
    • there's a hg-archival file (hidden, filename starting with a dot) in the package that should be removed
    • it mentions octave 3.0 has minimum dependency. Does the package really works in that Octave version?
    • why are you releasing it under GPLv2+ instead of GPLv3+?
    • the NEWS file only mentions version 0.0.0
    • can you put your email in front of your name in the DESCRIPTION file and in each of the files (either in front of your name in the first line of the copyright notice) or a separate line after the documentation (I prefer the first but in core it's done the later).
    • for the DESCRIPTION file there's two different lines, SystemRequirements and BuilRequires. The first is for applications that must be installed in the system, the second for libraries required for the build. You require the dolfin libraries so they should be listed.
    • the src/function.cc does not have a copyright notice
    • you have a couple of functions marked as for internal use only such as generate_fs. If they are going to be used by the other .m functions only you should place them inside a directory named private in inst/. If they are not meant to be used and are only for your own use during development don't distribute them and place them inside something such as devel at the root of the package.
    • What's the difference between Jacobian/Linear/Residual form? You even forgot to change the naem on the error message and program name in Residual form. I'd recommend you write a function inside the private directory that takes the function name as argument to avoid code duplication. You have a lot of code duplication in places such as import_ufl_* which may cause maintenance problems later.

    Note, because this wasn't released you don't need to change the version number. Just make the changes and release under the same number if you want (though since this is the first release, maybe it should be 0.0.0 instead of 0.0.1)

     
  • Marco

    Marco - 2013-09-11
     
  • Marco

    Marco - 2013-09-11
     
  • Carnë Draug

    Carnë Draug - 2013-09-11

    I'm a bit confused with two points:

    • I understand Dolfin as a System and Build Requirement but is ffc a library or application? I don't see it as header anywhere. Is it really both a build and system requirement?
    • why do you have a post install script moving those functions meant to internal use into a private directory? Why don't you create a private directory and place the functions there yourself? Look for example at the image package.
    • also taking a closer look at what you wanted to do by moving the oct files into the private directory may not be acceptable. I'll mwrite an e-mail on the mailing list and see what others think.
     
    • Marco

      Marco - 2013-09-11

      ffc is an application required when I build the pkg and also when the user use the pkg

      for the post_install I have answered in the maint list: I have to do polymorphism and thus I'm moving file to the spedific folder @mesh, @function

       
  • Marco

    Marco - 2013-09-18
     
  • Marco

    Marco - 2013-09-18
     
  • Marco

    Marco - 2013-10-26

    Here it is a new version of the pkg.

     
    Last edit: Marco 2013-10-27
  • Carnë Draug

    Carnë Draug - 2013-10-31

    You need to update the release date on the DESCRIPTION file (and probably also need to update the repository online?). Also, please don't use yyyy-dd-mm for the date, use yyyy-mm-dd. Don't forget to generate the html after that.

    And why all the commented code on the post_install function? We have a revision control system , just remove the code.

     
  • Marco

    Marco - 2013-11-09

    Hi,
    thanks for the suggestion.
    Here it is a new version of the pkg and of the html.

     
    Last edit: Marco 2013-11-09
  • Julien Bect

    Julien Bect - 2017-02-17
    • status: open --> closed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks