octave-dev

[OctDev] control 2.3.53 released

[Carnë D. <car...@gm...>]

Hi everyone

a new release of control package is out, version 2.3.53, by Lukas Reichlin.
Enjoy Octave responsibly.

Carnë

Re: [OctDev] control 2.3.53 released

[Rafael L. <ra...@la...>]

* Carnë Draug <car...@gm...> [2012-08-27 16:43]:

> a new release of control package is out, version 2.3.53, by Lukas Reichlin.

In exercising the tests in inst/@lti/minreal.m, I got the error below.
Is it normal?

I am running octave 3.6.2 on a Debian unstable system.

Rafael

P.S.: I do not have an account on SF currently.  Please, feel free to
forward this report to the Bug Tracker, if this is a real issue.


###########################################################################
octave:1> test ("@lti/minreal")
  ***** assert (Ar, Ae, 1e-4);
!!!!! test failed
assert (Ar,Ae,1e-4) expected
   1.00000  -0.03930  -0.09800  -0.10660   0.07810  -0.23300   0.07770
   0.00000   1.03120   0.27170   0.26090  -0.15330   0.67580  -0.35530
   0.00000   0.00000   1.38870   0.66990  -0.42810   1.63890  -0.76150
   0.00000   0.00000   0.00000  -1.21470   0.24230  -0.97920   0.47880
   0.00000   0.00000   0.00000   0.00000  -1.05450   0.50350  -0.27880
   0.00000   0.00000   0.00000   0.00000   0.00000   1.63550  -0.43230
   0.00000   0.00000   0.00000   0.00000   0.00000   0.00000   1.00000
but got
   1.00000  -0.03935   0.09802   0.10656   0.07805  -0.23302   0.07773
   0.00000   1.03122  -0.27169  -0.26093  -0.15327   0.67578  -0.35529
   0.00000   0.00000   1.38869   0.66991   0.42806  -1.63894   0.76153
   0.00000   0.00000   0.00000   1.21467   0.24232  -0.97919   0.47884
   0.00000   0.00000   0.00000   0.00000   1.05454  -0.50348   0.27881
   0.00000   0.00000   0.00000   0.00000   0.00000   1.63547  -0.43234
   0.00000   0.00000   0.00000   0.00000   0.00000   0.00000  -1.00000
maximum absolute error 3.27784 exceeds tolerance 0.0001
shared variables 
  scalar structure containing the fields:

    Ar =

       1.00000  -0.03935   0.09802   0.10656   0.07805  -0.23302   0.07773
       0.00000   1.03122  -0.27169  -0.26093  -0.15327   0.67578  -0.35529
       0.00000   0.00000   1.38869   0.66991   0.42806  -1.63894   0.76153
       0.00000   0.00000   0.00000   1.21467   0.24232  -0.97919   0.47884
       0.00000   0.00000   0.00000   0.00000   1.05454  -0.50348   0.27881
       0.00000   0.00000   0.00000   0.00000   0.00000   1.63547  -0.43234
       0.00000   0.00000   0.00000   0.00000   0.00000   0.00000  -1.00000

    Br =

      -5.5968e-01   2.3631e-01
      -4.8427e-01  -4.9770e-02
       4.7273e-01   1.4915e-01
       1.8019e-01   1.1574e+00
      -5.9948e-01  -1.5560e-01
      -1.7294e-01  -3.9991e-01
       1.8949e-17  -2.5000e-01

    Cr =

       0.00000   0.00000   0.00000   0.00000   0.00000   0.00000   4.00000
       0.00000   0.00000   0.00000   0.00000   0.00000   3.15238  -1.75000

    Dr =

       0   0
       0   0

    Er =

       0.40999   0.25895  -0.50798   0.31085   0.07054   0.14290  -0.14769
      -0.76292  -0.34645  -0.09918   0.30065   0.06189   0.24831  -0.01523
      -0.11198   0.21245  -0.41840  -0.12877  -0.05690   0.42134   0.61817
       0.00000   0.11215   0.00387  -0.27713  -0.07584   0.09747   0.39231
       0.00000   0.00000   0.37082  -0.42899  -0.10064  -0.14015   0.26995
       0.00000   0.00000   0.00000   0.00000   0.94581  -0.22115   0.23779
       0.00000   0.00000   0.00000   0.57107  -0.26478  -0.59479   0.50000

    Ae =

       1.00000  -0.03930  -0.09800  -0.10660   0.07810  -0.23300   0.07770
       0.00000   1.03120   0.27170   0.26090  -0.15330   0.67580  -0.35530
       0.00000   0.00000   1.38870   0.66990  -0.42810   1.63890  -0.76150
       0.00000   0.00000   0.00000  -1.21470   0.24230  -0.97920   0.47880
       0.00000   0.00000   0.00000   0.00000  -1.05450   0.50350  -0.27880
       0.00000   0.00000   0.00000   0.00000   0.00000   1.63550  -0.43230
       0.00000   0.00000   0.00000   0.00000   0.00000   0.00000   1.00000

    Be =

      -0.55970   0.23630
      -0.48430  -0.04980
      -0.47270  -0.14910
       0.18020   1.15740
       0.59950   0.15560
      -0.17290  -0.39990
       0.00000   0.25000

    Ce =

       0.00000   0.00000   0.00000   0.00000   0.00000   0.00000   4.00000
       0.00000   0.00000   0.00000   0.00000   0.00000   3.15240  -1.75000

    De =

       0   0
       0   0

    Ee =

       0.41000   0.25900   0.50800  -0.31090   0.07050   0.14290  -0.14770
      -0.76290  -0.34640   0.09920  -0.30070   0.06190   0.24830  -0.01520
       0.11200  -0.21240  -0.41840  -0.12880   0.05690  -0.42130  -0.61820
       0.00000   0.11220  -0.00390   0.27710  -0.07580   0.09750   0.39230
       0.00000   0.00000   0.37080  -0.42900   0.10060   0.14020  -0.26990
       0.00000   0.00000   0.00000   0.00000   0.94580  -0.22110   0.23780
       0.00000   0.00000   0.00000   0.57110   0.26480   0.59480  -0.50000

Re: [OctDev] control 2.3.53 released

[Rafael L. <ra...@la...>]

* Rafael Laboissiere <ra...@la...> [2012-08-30 23:47]:

> * Carnë Draug <car...@gm...> [2012-08-27 16:43]:
> 
> > a new release of control package is out, version 2.3.53, by Lukas Reichlin.
> 
> In exercising the tests in inst/@lti/minreal.m, I got the error below.
> Is it normal?
> 
> I am running octave 3.6.2 on a Debian unstable system.
> 
> [snip]

Testing ltimodels and bstmodred also yield errors, cf below.

Rafael


#############################################################################

[ltimodels]
  ***** assert (ac, ac_e, 1e-4);
!!!!! test failed
assert (ac,ac_e,1e-4) expected
   0.00000   0.00000   0.00000   0.00000  -1.26270   0.43340   0.46660
   0.00000   2.00000   0.00000  -3.74170  -0.85200   0.29240  -0.43420
   0.00000   0.00000   1.78620   0.37800  -0.26510  -0.77230   0.00000
   0.00000   0.00000   0.00000   3.74170   0.85200  -0.29240   0.43420
   0.00000   0.00000   0.00000   0.00000  -1.55400   0.53340   0.57420
   0.00000   0.00000   0.00000   0.00000  -0.65330   0.22420   0.24140
   0.00000   0.00000   0.00000   0.00000  -0.58920   0.20220   0.21770
but got
   0.00000  -0.00000  -0.00000   0.00000   1.35857  -0.38229  -0.09025
   0.00000   2.00000   0.00000  -3.74166   0.87321   0.48735   0.00000
   0.00000   0.00000   1.78619   0.37796  -0.03591   0.06435  -0.81316
   0.00000   0.00000   0.00000   3.74166  -0.87321  -0.48735  -0.00000
   0.00000   0.00000   0.00000   0.00000   1.84482  -0.51912  -0.12255
   0.00000   0.00000   0.00000   0.00000  -0.51537   0.14502   0.03424
   0.00000   0.00000   0.00000   0.00000  -0.14986   0.04217   0.00996
maximum absolute error 3.39882 exceeds tolerance 0.0001
shared variables 
  scalar structure containing the fields:

    ac =

       0.00000  -0.00000  -0.00000   0.00000   1.35857  -0.38229  -0.09025
       0.00000   2.00000   0.00000  -3.74166   0.87321   0.48735   0.00000
       0.00000   0.00000   1.78619   0.37796  -0.03591   0.06435  -0.81316
       0.00000   0.00000   0.00000   3.74166  -0.87321  -0.48735  -0.00000
       0.00000   0.00000   0.00000   0.00000   1.84482  -0.51912  -0.12255
       0.00000   0.00000   0.00000   0.00000  -0.51537   0.14502   0.03424
       0.00000   0.00000   0.00000   0.00000  -0.14986   0.04217   0.00996

    ec =

       1.83254   1.00000   2.37525   0.00000   0.97073  -1.73928  -0.18050
      -0.48868   0.00000   0.37702  -0.53452   0.02539  -0.04550   0.57499
       0.17277  -0.00000  -0.13330  -1.13389   0.01796  -0.03217   0.40658
       0.00000   0.00000   0.00000  -0.00000  -0.87321  -0.48735   0.00000
       0.00000   0.00000   0.00000   0.00000   1.00048  -0.00173   0.02189
       0.00000   0.00000   0.00000   0.00000   0.00000   1.00155  -0.03914
       0.00000   0.00000   0.00000   0.00000   0.00000   0.00000   1.22226

    bc =

       1.00000   2.00000   3.00000
       2.00000   1.00000   0.00000
       0.00000   0.00000   0.00000
       0.00000   0.00000   0.00000
       0.00000   0.00000   0.00000
       0.00000   0.00000   0.00000
       0.00000   0.00000   0.00000

    cc =

     Columns 1 through 5:

       1.5181e-16   1.0000e+00  -9.6723e-17   1.8014e-16   1.3586e+00
      -3.6651e-01   9.6902e-18  -9.8026e-01  -1.6036e+00   2.5394e-02

     Columns 6 and 7:

      -3.8229e-01  -9.0251e-02
      -4.5500e-02   5.7499e-01

    q =

       0.00000   1.00000  -0.00000   0.00000   0.00000   0.00000   0.00000
       0.00000  -0.00000   0.70711   0.00000  -0.03807   0.06808  -0.70279
       0.00000  -0.00000  -0.00000  -0.00000   0.87278   0.48811   0.00000
       0.00000   0.00000   0.00000  -1.00000  -0.00000  -0.00000  -0.00000
       0.00000   0.00000  -0.00000   0.00000   0.48513  -0.86746  -0.11031
       0.00000  -0.00000   0.70711   0.00000   0.03807  -0.06808   0.70279
       1.00000   0.00000   0.00000   0.00000   0.00000   0.00000   0.00000

    z =

       0.00000   1.00000   0.00000   0.00000   0.00000   0.00000   0.00000
       0.61085  -0.00000   0.79175   0.00000   0.00000   0.00000   0.00000
      -0.48868   0.00000   0.37702  -0.53452   0.02539  -0.04550   0.57499
      -0.00000   0.00000   0.00000  -0.00000   0.48536  -0.86964  -0.09025
      -0.61085   0.00000   0.47128   0.26726  -0.02539   0.04550  -0.57499
       0.12217  -0.00000  -0.09426  -0.80178  -0.02539   0.04550  -0.57499
       0.00000  -0.00000  -0.00000   0.00000   0.87321   0.48735   0.00000

    ncont =  3
    ac_e =

       0.00000   0.00000   0.00000   0.00000  -1.26270   0.43340   0.46660
       0.00000   2.00000   0.00000  -3.74170  -0.85200   0.29240  -0.43420
       0.00000   0.00000   1.78620   0.37800  -0.26510  -0.77230   0.00000
       0.00000   0.00000   0.00000   3.74170   0.85200  -0.29240   0.43420
       0.00000   0.00000   0.00000   0.00000  -1.55400   0.53340   0.57420
       0.00000   0.00000   0.00000   0.00000  -0.65330   0.22420   0.24140
       0.00000   0.00000   0.00000   0.00000  -0.58920   0.20220   0.21770

    ec_e =

      -1.83250   1.00000   2.37520   0.00000  -0.82140   0.28190   1.80160
       0.48870   0.00000   0.37700  -0.53450   0.18740   0.54610   0.00000
      -0.17280   0.00000  -0.13330  -1.13390   0.13250   0.38610   0.00000
       0.00000   0.00000   0.00000   0.00000   0.85200  -0.29240   0.43420
       0.00000   0.00000   0.00000   0.00000  -1.02600  -0.14960   0.00000
       0.00000   0.00000   0.00000   0.00000   0.00000   1.19370   0.00000
       0.00000   0.00000   0.00000   0.00000   0.00000   0.00000   1.00000

    bc_e =

       1   2   3
       2   1   0
       0   0   0
       0   0   0
       0   0   0
       0   0   0
       0   0   0

    cc_e =

       0.00000   1.00000   0.00000   0.00000  -1.26270   0.43340   0.46660
       0.36650   0.00000  -0.98030  -1.60360   0.18740   0.54610   0.00000

    q_e =

       0.00000   1.00000   0.00000   0.00000   0.00000   0.00000   0.00000
       0.00000   0.00000   0.70710   0.00000   0.27400  -0.65190   0.00000
       0.00000   0.00000   0.00000   0.00000   0.83040   0.34910  -0.43420
       0.00000   0.00000   0.00000  -1.00000   0.00000   0.00000   0.00000
       0.00000   0.00000   0.00000   0.00000   0.40030   0.16830   0.90080
       0.00000   0.00000   0.70710   0.00000  -0.27400   0.65190   0.00000
       1.00000   0.00000   0.00000   0.00000   0.00000   0.00000   0.00000

    z_e =

       0.00000   1.00000   0.00000   0.00000   0.00000   0.00000   0.00000
      -0.61080   0.00000   0.79170   0.00000   0.00000   0.00000   0.00000
       0.48870   0.00000   0.37700  -0.53450   0.18740   0.54610   0.00000
       0.00000   0.00000   0.00000   0.00000  -0.41070   0.14100   0.90080
       0.61080   0.00000   0.47130   0.26730  -0.18740  -0.54610   0.00000
      -0.12220   0.00000  -0.09430  -0.80180  -0.18740  -0.54610   0.00000
       0.00000   0.00000   0.00000   0.00000  -0.85200   0.29240  -0.43420

    ncont_e =  3

[bstmodred]
  ***** assert (Mo, Me, 1e-4);
!!!!! test failed
assert (Mo,Me,1e-4) expected
   1.27290   0.00000   6.59470   0.00000  -3.42290   0.13310  -0.13310
   0.00000   0.81690   0.00000   2.48210   0.00000  -0.08620  -0.08620
  -2.98890   0.00000  -2.90280   0.00000  -0.36920  -2.67770   2.67770
   0.00000  -3.39210   0.00000  -3.11260   0.00000  -3.57670  -3.57670
  -1.47670   0.00000  -2.03390   0.00000  -0.61070  -2.30330   2.30330
  -0.69070  -0.68820   0.07790   0.09580  -0.00380   0.00000   0.00000
   0.06760   0.00000   0.65320   0.00000  -0.75220   0.00000   0.00000
   0.69070  -0.68820  -0.07790   0.09580   0.00380   0.00000   0.00000
but got
   1.27295   0.00000  -6.59466   0.00000  -3.42287  -0.13307   0.13307
  -0.00000   0.81688   0.00000   2.48210   0.00000   0.08620   0.08620
   2.98890  -0.00000  -2.90283   0.00000   0.36919  -2.67775   2.67775
  -0.00000  -3.39208  -0.00000  -3.11263   0.00000   3.57669   3.57669
  -1.47666   0.00000   2.03393   0.00000  -0.61070   2.30328  -2.30328
   0.69073   0.68823   0.07791  -0.09576   0.00376   0.00000   0.00000
  -0.06755  -0.00000   0.65316   0.00000   0.75223   0.00000   0.00000
  -0.69073   0.68823  -0.07791  -0.09576  -0.00376   0.00000   0.00000
maximum absolute error 13.1894 exceeds tolerance 0.0001
shared variables 
  scalar structure containing the fields:

    Mo =

       1.27295   0.00000  -6.59466   0.00000  -3.42287  -0.13307   0.13307
      -0.00000   0.81688   0.00000   2.48210   0.00000   0.08620   0.08620
       2.98890  -0.00000  -2.90283   0.00000   0.36919  -2.67775   2.67775
      -0.00000  -3.39208  -0.00000  -3.11263   0.00000   3.57669   3.57669
      -1.47666   0.00000   2.03393   0.00000  -0.61070   2.30328  -2.30328
       0.69073   0.68823   0.07791  -0.09576   0.00376   0.00000   0.00000
      -0.06755  -0.00000   0.65316   0.00000   0.75223   0.00000   0.00000
      -0.69073   0.68823  -0.07791  -0.09576  -0.00376   0.00000   0.00000

    Me =

       1.27290   0.00000   6.59470   0.00000  -3.42290   0.13310  -0.13310
       0.00000   0.81690   0.00000   2.48210   0.00000  -0.08620  -0.08620
      -2.98890   0.00000  -2.90280   0.00000  -0.36920  -2.67770   2.67770
       0.00000  -3.39210   0.00000  -3.11260   0.00000  -3.57670  -3.57670
      -1.47670   0.00000  -2.03390   0.00000  -0.61070  -2.30330   2.30330
      -0.69070  -0.68820   0.07790   0.09580  -0.00380   0.00000   0.00000
       0.06760   0.00000   0.65320   0.00000  -0.75220   0.00000   0.00000
       0.69070  -0.68820  -0.07790   0.09580   0.00380   0.00000   0.00000

    Info =

      scalar structure containing the fields:

        n =  7
        ns =  7
        hsv =

           0.880263
           0.850619
           0.803778
           0.449390
           0.397312
           0.021408
           0.020850

        nu = 0
        nr =  5

    HSVe =

       0.880300
       0.850600
       0.803800
       0.449400
       0.397300
       0.021400
       0.020900

Re: [OctDev] control 2.3.53 released

[Philip N. <pr....@hc...>]

PMFJI

but, uhm....

Lukas Reichlin wrote:
> On 03.09.2012, at 10:39, Rafael Laboissiere<ra...@la...>  wrote:
>
>> * Rafael Laboissiere<ra...@la...>  [2012-08-30 23:47]:
>>
>>> * Carnë Draug<car...@gm...>  [2012-08-27 16:43]:
>>>
>>>> a new release of control package is out, version 2.3.53, by Lukas Reichlin.
>>>
>>> In exercising the tests in inst/@lti/minreal.m, I got the error below.
>>> Is it normal?
> Hi Rafael,
>
> You can check whether the observed and expected results are equivalent state-space models (i.e. state-transformation, see command prescale for formulae). This can be done, e.g., by inspection of the Hankel singular values (command hsvd), time response (step, impulse) or frequency response (sigma).
> If they are the same, there should be nothing to worry about. If you want the same results, use Reference BLAS (and LAPACK) from www.netlib.org instead of ATLAS which you are probably using. The SLICOT authors recommend the use of the reference implementations. Correct results are more important than minor speed advantages of automatically tuned linear algebra software, aren't they? :-)

... shouldn't such an interpretation be reflected in the tests then, 
rather than a plain "assert" comparison that depends on what (allowed!) 
dependencies happen to be in place.
Currently the test just seems to yield confusion.

Philip

Re: [OctDev] control 2.3.53 released

[Lukas R. <luk...@gm...>]

On 03.09.2012, at 12:29, Philip Nienhuis <pr....@hc...> wrote:

> PMFJI
> 
> but, uhm....
> 
> Lukas Reichlin wrote:
>> On 03.09.2012, at 10:39, Rafael Laboissiere<ra...@la...>  wrote:
>> 
>>> * Rafael Laboissiere<ra...@la...>  [2012-08-30 23:47]:
>>> 
>>>> * Carnë Draug<car...@gm...>  [2012-08-27 16:43]:
>>>> 
>>>>> a new release of control package is out, version 2.3.53, by Lukas Reichlin.
>>>> 
>>>> In exercising the tests in inst/@lti/minreal.m, I got the error below.
>>>> Is it normal?
>> Hi Rafael,
>> 
>> You can check whether the observed and expected results are equivalent state-space models (i.e. state-transformation, see command prescale for formulae). This can be done, e.g., by inspection of the Hankel singular values (command hsvd), time response (step, impulse) or frequency response (sigma).
>> If they are the same, there should be nothing to worry about. If you want the same results, use Reference BLAS (and LAPACK) from www.netlib.org instead of ATLAS which you are probably using. The SLICOT authors recommend the use of the reference implementations. Correct results are more important than minor speed advantages of automatically tuned linear algebra software, aren't they? :-)
> 
> ... shouldn't such an interpretation be reflected in the tests then, rather than a plain "assert" comparison that depends on what (allowed!) dependencies happen to be in place.
> Currently the test just seems to yield confusion.
> 
> Philip

Hi Philip

I see your point, but currently, the tests are such that if they pass, one can trust the results. If they fail, it is up to the user to check whether the results in this special case are correct and if he has confidence in his SLICOT dependencies (e.g. ATLAS) in general. I don't know how to do this automatically and how to avoid false positive tests (which would be a very bad thing). Do you have any ideas how to check the results of the failing tests?

Lukas 

Re: [OctDev] control 2.3.53 released

[Lukas R. <luk...@gm...>]

On 03.09.2012, at 10:39, Rafael Laboissiere <ra...@la...> wrote:

> * Rafael Laboissiere <ra...@la...> [2012-08-30 23:47]:
> 
>> * Carnë Draug <car...@gm...> [2012-08-27 16:43]:
>> 
>>> a new release of control package is out, version 2.3.53, by Lukas Reichlin.
>> 
>> In exercising the tests in inst/@lti/minreal.m, I got the error below.
>> Is it normal?
>> 
>> I am running octave 3.6.2 on a Debian unstable system.
>> 
>> [snip]
> 
> Testing ltimodels and bstmodred also yield errors, cf below.
> 
> Rafael
> 
> 
> #############################################################################
> 
> [ltimodels]
>  ***** assert (ac, ac_e, 1e-4);
> !!!!! test failed
> assert (ac,ac_e,1e-4) expected
>   0.00000   0.00000   0.00000   0.00000  -1.26270   0.43340   0.46660
>   0.00000   2.00000   0.00000  -3.74170  -0.85200   0.29240  -0.43420
>   0.00000   0.00000   1.78620   0.37800  -0.26510  -0.77230   0.00000
>   0.00000   0.00000   0.00000   3.74170   0.85200  -0.29240   0.43420
>   0.00000   0.00000   0.00000   0.00000  -1.55400   0.53340   0.57420
>   0.00000   0.00000   0.00000   0.00000  -0.65330   0.22420   0.24140
>   0.00000   0.00000   0.00000   0.00000  -0.58920   0.20220   0.21770
> but got
>   0.00000  -0.00000  -0.00000   0.00000   1.35857  -0.38229  -0.09025
>   0.00000   2.00000   0.00000  -3.74166   0.87321   0.48735   0.00000
>   0.00000   0.00000   1.78619   0.37796  -0.03591   0.06435  -0.81316
>   0.00000   0.00000   0.00000   3.74166  -0.87321  -0.48735  -0.00000
>   0.00000   0.00000   0.00000   0.00000   1.84482  -0.51912  -0.12255
>   0.00000   0.00000   0.00000   0.00000  -0.51537   0.14502   0.03424
>   0.00000   0.00000   0.00000   0.00000  -0.14986   0.04217   0.00996
> maximum absolute error 3.39882 exceeds tolerance 0.0001
> shared variables 
>  scalar structure containing the fields:
> 
>    ac =
> 
>       0.00000  -0.00000  -0.00000   0.00000   1.35857  -0.38229  -0.09025
>       0.00000   2.00000   0.00000  -3.74166   0.87321   0.48735   0.00000
>       0.00000   0.00000   1.78619   0.37796  -0.03591   0.06435  -0.81316
>       0.00000   0.00000   0.00000   3.74166  -0.87321  -0.48735  -0.00000
>       0.00000   0.00000   0.00000   0.00000   1.84482  -0.51912  -0.12255
>       0.00000   0.00000   0.00000   0.00000  -0.51537   0.14502   0.03424
>       0.00000   0.00000   0.00000   0.00000  -0.14986   0.04217   0.00996
> 
>    ec =
> 
>       1.83254   1.00000   2.37525   0.00000   0.97073  -1.73928  -0.18050
>      -0.48868   0.00000   0.37702  -0.53452   0.02539  -0.04550   0.57499
>       0.17277  -0.00000  -0.13330  -1.13389   0.01796  -0.03217   0.40658
>       0.00000   0.00000   0.00000  -0.00000  -0.87321  -0.48735   0.00000
>       0.00000   0.00000   0.00000   0.00000   1.00048  -0.00173   0.02189
>       0.00000   0.00000   0.00000   0.00000   0.00000   1.00155  -0.03914
>       0.00000   0.00000   0.00000   0.00000   0.00000   0.00000   1.22226
> 
>    bc =
> 
>       1.00000   2.00000   3.00000
>       2.00000   1.00000   0.00000
>       0.00000   0.00000   0.00000
>       0.00000   0.00000   0.00000
>       0.00000   0.00000   0.00000
>       0.00000   0.00000   0.00000
>       0.00000   0.00000   0.00000
> 
>    cc =
> 
>     Columns 1 through 5:
> 
>       1.5181e-16   1.0000e+00  -9.6723e-17   1.8014e-16   1.3586e+00
>      -3.6651e-01   9.6902e-18  -9.8026e-01  -1.6036e+00   2.5394e-02
> 
>     Columns 6 and 7:
> 
>      -3.8229e-01  -9.0251e-02
>      -4.5500e-02   5.7499e-01
> 
>    q =
> 
>       0.00000   1.00000  -0.00000   0.00000   0.00000   0.00000   0.00000
>       0.00000  -0.00000   0.70711   0.00000  -0.03807   0.06808  -0.70279
>       0.00000  -0.00000  -0.00000  -0.00000   0.87278   0.48811   0.00000
>       0.00000   0.00000   0.00000  -1.00000  -0.00000  -0.00000  -0.00000
>       0.00000   0.00000  -0.00000   0.00000   0.48513  -0.86746  -0.11031
>       0.00000  -0.00000   0.70711   0.00000   0.03807  -0.06808   0.70279
>       1.00000   0.00000   0.00000   0.00000   0.00000   0.00000   0.00000
> 
>    z =
> 
>       0.00000   1.00000   0.00000   0.00000   0.00000   0.00000   0.00000
>       0.61085  -0.00000   0.79175   0.00000   0.00000   0.00000   0.00000
>      -0.48868   0.00000   0.37702  -0.53452   0.02539  -0.04550   0.57499
>      -0.00000   0.00000   0.00000  -0.00000   0.48536  -0.86964  -0.09025
>      -0.61085   0.00000   0.47128   0.26726  -0.02539   0.04550  -0.57499
>       0.12217  -0.00000  -0.09426  -0.80178  -0.02539   0.04550  -0.57499
>       0.00000  -0.00000  -0.00000   0.00000   0.87321   0.48735   0.00000
> 
>    ncont =  3
>    ac_e =
> 
>       0.00000   0.00000   0.00000   0.00000  -1.26270   0.43340   0.46660
>       0.00000   2.00000   0.00000  -3.74170  -0.85200   0.29240  -0.43420
>       0.00000   0.00000   1.78620   0.37800  -0.26510  -0.77230   0.00000
>       0.00000   0.00000   0.00000   3.74170   0.85200  -0.29240   0.43420
>       0.00000   0.00000   0.00000   0.00000  -1.55400   0.53340   0.57420
>       0.00000   0.00000   0.00000   0.00000  -0.65330   0.22420   0.24140
>       0.00000   0.00000   0.00000   0.00000  -0.58920   0.20220   0.21770
> 
>    ec_e =
> 
>      -1.83250   1.00000   2.37520   0.00000  -0.82140   0.28190   1.80160
>       0.48870   0.00000   0.37700  -0.53450   0.18740   0.54610   0.00000
>      -0.17280   0.00000  -0.13330  -1.13390   0.13250   0.38610   0.00000
>       0.00000   0.00000   0.00000   0.00000   0.85200  -0.29240   0.43420
>       0.00000   0.00000   0.00000   0.00000  -1.02600  -0.14960   0.00000
>       0.00000   0.00000   0.00000   0.00000   0.00000   1.19370   0.00000
>       0.00000   0.00000   0.00000   0.00000   0.00000   0.00000   1.00000
> 
>    bc_e =
> 
>       1   2   3
>       2   1   0
>       0   0   0
>       0   0   0
>       0   0   0
>       0   0   0
>       0   0   0
> 
>    cc_e =
> 
>       0.00000   1.00000   0.00000   0.00000  -1.26270   0.43340   0.46660
>       0.36650   0.00000  -0.98030  -1.60360   0.18740   0.54610   0.00000
> 
>    q_e =
> 
>       0.00000   1.00000   0.00000   0.00000   0.00000   0.00000   0.00000
>       0.00000   0.00000   0.70710   0.00000   0.27400  -0.65190   0.00000
>       0.00000   0.00000   0.00000   0.00000   0.83040   0.34910  -0.43420
>       0.00000   0.00000   0.00000  -1.00000   0.00000   0.00000   0.00000
>       0.00000   0.00000   0.00000   0.00000   0.40030   0.16830   0.90080
>       0.00000   0.00000   0.70710   0.00000  -0.27400   0.65190   0.00000
>       1.00000   0.00000   0.00000   0.00000   0.00000   0.00000   0.00000
> 
>    z_e =
> 
>       0.00000   1.00000   0.00000   0.00000   0.00000   0.00000   0.00000
>      -0.61080   0.00000   0.79170   0.00000   0.00000   0.00000   0.00000
>       0.48870   0.00000   0.37700  -0.53450   0.18740   0.54610   0.00000
>       0.00000   0.00000   0.00000   0.00000  -0.41070   0.14100   0.90080
>       0.61080   0.00000   0.47130   0.26730  -0.18740  -0.54610   0.00000
>      -0.12220   0.00000  -0.09430  -0.80180  -0.18740  -0.54610   0.00000
>       0.00000   0.00000   0.00000   0.00000  -0.85200   0.29240  -0.43420
> 
>    ncont_e =  3
> 
> [bstmodred]
>  ***** assert (Mo, Me, 1e-4);
> !!!!! test failed
> assert (Mo,Me,1e-4) expected
>   1.27290   0.00000   6.59470   0.00000  -3.42290   0.13310  -0.13310
>   0.00000   0.81690   0.00000   2.48210   0.00000  -0.08620  -0.08620
>  -2.98890   0.00000  -2.90280   0.00000  -0.36920  -2.67770   2.67770
>   0.00000  -3.39210   0.00000  -3.11260   0.00000  -3.57670  -3.57670
>  -1.47670   0.00000  -2.03390   0.00000  -0.61070  -2.30330   2.30330
>  -0.69070  -0.68820   0.07790   0.09580  -0.00380   0.00000   0.00000
>   0.06760   0.00000   0.65320   0.00000  -0.75220   0.00000   0.00000
>   0.69070  -0.68820  -0.07790   0.09580   0.00380   0.00000   0.00000
> but got
>   1.27295   0.00000  -6.59466   0.00000  -3.42287  -0.13307   0.13307
>  -0.00000   0.81688   0.00000   2.48210   0.00000   0.08620   0.08620
>   2.98890  -0.00000  -2.90283   0.00000   0.36919  -2.67775   2.67775
>  -0.00000  -3.39208  -0.00000  -3.11263   0.00000   3.57669   3.57669
>  -1.47666   0.00000   2.03393   0.00000  -0.61070   2.30328  -2.30328
>   0.69073   0.68823   0.07791  -0.09576   0.00376   0.00000   0.00000
>  -0.06755  -0.00000   0.65316   0.00000   0.75223   0.00000   0.00000
>  -0.69073   0.68823  -0.07791  -0.09576  -0.00376   0.00000   0.00000
> maximum absolute error 13.1894 exceeds tolerance 0.0001
> shared variables 
>  scalar structure containing the fields:
> 
>    Mo =
> 
>       1.27295   0.00000  -6.59466   0.00000  -3.42287  -0.13307   0.13307
>      -0.00000   0.81688   0.00000   2.48210   0.00000   0.08620   0.08620
>       2.98890  -0.00000  -2.90283   0.00000   0.36919  -2.67775   2.67775
>      -0.00000  -3.39208  -0.00000  -3.11263   0.00000   3.57669   3.57669
>      -1.47666   0.00000   2.03393   0.00000  -0.61070   2.30328  -2.30328
>       0.69073   0.68823   0.07791  -0.09576   0.00376   0.00000   0.00000
>      -0.06755  -0.00000   0.65316   0.00000   0.75223   0.00000   0.00000
>      -0.69073   0.68823  -0.07791  -0.09576  -0.00376   0.00000   0.00000
> 
>    Me =
> 
>       1.27290   0.00000   6.59470   0.00000  -3.42290   0.13310  -0.13310
>       0.00000   0.81690   0.00000   2.48210   0.00000  -0.08620  -0.08620
>      -2.98890   0.00000  -2.90280   0.00000  -0.36920  -2.67770   2.67770
>       0.00000  -3.39210   0.00000  -3.11260   0.00000  -3.57670  -3.57670
>      -1.47670   0.00000  -2.03390   0.00000  -0.61070  -2.30330   2.30330
>      -0.69070  -0.68820   0.07790   0.09580  -0.00380   0.00000   0.00000
>       0.06760   0.00000   0.65320   0.00000  -0.75220   0.00000   0.00000
>       0.69070  -0.68820  -0.07790   0.09580   0.00380   0.00000   0.00000
> 
>    Info =
> 
>      scalar structure containing the fields:
> 
>        n =  7
>        ns =  7
>        hsv =
> 
>           0.880263
>           0.850619
>           0.803778
>           0.449390
>           0.397312
>           0.021408
>           0.020850
> 
>        nu = 0
>        nr =  5
> 
>    HSVe =
> 
>       0.880300
>       0.850600
>       0.803800
>       0.449400
>       0.397300
>       0.021400
>       0.020900

Hi Rafael,

You can check whether the observed and expected results are equivalent state-space models (i.e. state-transformation, see command prescale for formulae). This can be done, e.g., by inspection of the Hankel singular values (command hsvd), time response (step, impulse) or frequency response (sigma).
If they are the same, there should be nothing to worry about. If you want the same results, use Reference BLAS (and LAPACK) from www.netlib.org instead of ATLAS which you are probably using. The SLICOT authors recommend the use of the reference implementations. Correct results are more important than minor speed advantages of automatically tuned linear algebra software, aren't they? :-)

Regards,
Lukas

Re: [OctDev] control 2.3.53 released

[marco a. <mar...@gm...>]

On 9/3/2012 12:03 PM, Lukas Reichlin wrote:
> On 03.09.2012, at 10:39, Rafael Laboissiere <ra...@la...> wrote:

> Hi Rafael,
>
> You can check whether the observed and expected results are equivalent state-space models (i.e. state-transformation, see command prescale for formulae). This can be done, e.g., by inspection of the Hankel singular values (command hsvd), time response (step, impulse) or frequency response (sigma).
> If they are the same, there should be nothing to worry about. If you want the same results, use Reference BLAS (and LAPACK) from www.netlib.org instead of ATLAS which you are probably using. The SLICOT authors recommend the use of the reference implementations. Correct results are more important than minor speed advantages of automatically tuned linear algebra software, aren't they? :-)
>
> Regards,
> Lukas
>

Lukas,
there is no guarantee to have the "expected" result
also with the reference lib.

Using Lapack 3.4.1 on cygwin


  test /home/marco/octave/control-2.3.53/@lti/minreal.m
   ***** assert (Ar, Ae, 1e-4);
!!!!! test failed
assert (Ar,Ae,1e-4) expected
    1.00000  -0.03930  -0.09800  -0.10660   0.07810  -0.23300   0.07770
    0.00000   1.03120   0.27170   0.26090  -0.15330   0.67580  -0.35530
    0.00000   0.00000   1.38870   0.66990  -0.42810   1.63890  -0.76150
    0.00000   0.00000   0.00000  -1.21470   0.24230  -0.97920   0.47880
    0.00000   0.00000   0.00000   0.00000  -1.05450   0.50350  -0.27880
    0.00000   0.00000   0.00000   0.00000   0.00000   1.63550  -0.43230
    0.00000   0.00000   0.00000   0.00000   0.00000   0.00000   1.00000
but got
    1.00000   0.03935   0.09802  -0.10656   0.07805  -0.23302   0.07773
    0.00000   1.03122   0.27169  -0.26093   0.15327  -0.67578   0.35529
    0.00000   0.00000   1.38869  -0.66991   0.42806  -1.63894   0.76153
    0.00000   0.00000   0.00000   1.21467  -0.24232   0.97919  -0.47884
    0.00000   0.00000   0.00000   0.00000   1.05454  -0.50348   0.27881
    0.00000   0.00000   0.00000   0.00000   0.00000   1.63547  -0.43234
    0.00000   0.00000   0.00000   0.00000   0.00000   0.00000   1.00000
maximum absolute error 3.27784 exceeds tolerance 0.0001

so we need to define a different test methodology

Regards
Marco

[OctDev] control 2.3.53 released

[Lukas R. <luk...@gm...>]

On 04.09.2012, at 14:03, marco atzeri <mar...@gm...> wrote:

> On 9/3/2012 12:03 PM, Lukas Reichlin wrote:
>> On 03.09.2012, at 10:39, Rafael Laboissiere <ra...@la...> wrote:
> 
>> Hi Rafael,
>> 
>> You can check whether the observed and expected results are equivalent state-space models (i.e. state-transformation, see command prescale for formulae). This can be done, e.g., by inspection of the Hankel singular values (command hsvd), time response (step, impulse) or frequency response (sigma).
>> If they are the same, there should be nothing to worry about. If you want the same results, use Reference BLAS (and LAPACK) from www.netlib.org instead of ATLAS which you are probably using. The SLICOT authors recommend the use of the reference implementations. Correct results are more important than minor speed advantages of automatically tuned linear algebra software, aren't they? :-)
>> 
>> Regards,
>> Lukas
>> 
> 
> Lukas,
> there is no guarantee to have the "expected" result
> also with the reference lib.
> 
> Using Lapack 3.4.1 on cygwin
> 
> 
> test /home/marco/octave/control-2.3.53/@lti/minreal.m
>  ***** assert (Ar, Ae, 1e-4);
> !!!!! test failed
> assert (Ar,Ae,1e-4) expected
>   1.00000  -0.03930  -0.09800  -0.10660   0.07810  -0.23300   0.07770
>   0.00000   1.03120   0.27170   0.26090  -0.15330   0.67580  -0.35530
>   0.00000   0.00000   1.38870   0.66990  -0.42810   1.63890  -0.76150
>   0.00000   0.00000   0.00000  -1.21470   0.24230  -0.97920   0.47880
>   0.00000   0.00000   0.00000   0.00000  -1.05450   0.50350  -0.27880
>   0.00000   0.00000   0.00000   0.00000   0.00000   1.63550  -0.43230
>   0.00000   0.00000   0.00000   0.00000   0.00000   0.00000   1.00000
> but got
>   1.00000   0.03935   0.09802  -0.10656   0.07805  -0.23302   0.07773
>   0.00000   1.03122   0.27169  -0.26093   0.15327  -0.67578   0.35529
>   0.00000   0.00000   1.38869  -0.66991   0.42806  -1.63894   0.76153
>   0.00000   0.00000   0.00000   1.21467  -0.24232   0.97919  -0.47884
>   0.00000   0.00000   0.00000   0.00000   1.05454  -0.50348   0.27881
>   0.00000   0.00000   0.00000   0.00000   0.00000   1.63547  -0.43234
>   0.00000   0.00000   0.00000   0.00000   0.00000   0.00000   1.00000
> maximum absolute error 3.27784 exceeds tolerance 0.0001
> 
> so we need to define a different test methodology
> 
> Regards
> Marco

Hi Marco

LAPACK 3.4.1 is not enough. You also need reference BLAS from Netlib. LAPACK + ATLAS doesn't count here. Do you have a different test methodology in mind?

Regards,
Lukas

Re: [OctDev] control 2.3.53 released

[Rafael L. <ra...@la...>]

* Lukas Reichlin <luk...@gm...> [2012-09-03 12:03]:

> On 03.09.2012, at 10:39, Rafael Laboissiere <ra...@la...> wrote:
> 
> > * Rafael Laboissiere <ra...@la...> [2012-08-30 23:47]:
> > 
> >> * Carnë Draug <car...@gm...> [2012-08-27 16:43]:
> >> 
> >>> a new release of control package is out, version 2.3.53, by Lukas Reichlin.
> >> 
> >> In exercising the tests in inst/@lti/minreal.m, I got the error below.
> >> Is it normal?
> >> 
> >> I am running octave 3.6.2 on a Debian unstable system.
> >> 
> >> [snip]
> > 
> > Testing ltimodels and bstmodred also yield errors, cf below.
> > 
> > [snip]
> 
> You can check whether the observed and expected results are equivalent
> state-space models (i.e. state-transformation, see command prescale for
> formulae). This can be done, e.g., by inspection of the Hankel singular
> values (command hsvd), time response (step, impulse) or frequency
> response (sigma).
>
> If they are the same, there should be nothing to worry about. If you
> want the same results, use Reference BLAS (and LAPACK) from
> www.netlib.org instead of ATLAS which you are probably using. The
> SLICOT authors recommend the use of the reference implementations.
> Correct results are more important than minor speed advantages of
> automatically tuned linear algebra software, aren't they? :-)

I built the control package on my Debian system with libblas-dev
installed and libatlas3-base, libatlas-dev, libopenblas-base, and
libopenblas-dev removed.  I still get the same errors in the unit
testings.  Here is the build log of the Debian package octave-control
(version 2.3.53-1) with the same errors:

https://buildd.debian.org/status/fetch.php?pkg=octave-control&arch=i386&ver=2.3.53-1&stamp=1346708061

It seems that using the Reference BLAS is not enough for getting rid of
the problem.

Rafael

Re: [OctDev] control 2.3.53 released

[Lukas R. <luk...@gm...>]

On 07.09.2012, at 13:37, Rafael Laboissiere wrote:

> * Lukas Reichlin <luk...@gm...> [2012-09-03 12:03]:
> 
>> On 03.09.2012, at 10:39, Rafael Laboissiere <ra...@la...> wrote:
>> 
>>> * Rafael Laboissiere <ra...@la...> [2012-08-30 23:47]:
>>> 
>>>> * Carnë Draug <car...@gm...> [2012-08-27 16:43]:
>>>> 
>>>>> a new release of control package is out, version 2.3.53, by Lukas Reichlin.
>>>> 
>>>> In exercising the tests in inst/@lti/minreal.m, I got the error below.
>>>> Is it normal?
>>>> 
>>>> I am running octave 3.6.2 on a Debian unstable system.
>>>> 
>>>> [snip]
>>> 
>>> Testing ltimodels and bstmodred also yield errors, cf below.
>>> 
>>> [snip]
>> 
>> You can check whether the observed and expected results are equivalent
>> state-space models (i.e. state-transformation, see command prescale for
>> formulae). This can be done, e.g., by inspection of the Hankel singular
>> values (command hsvd), time response (step, impulse) or frequency
>> response (sigma).
>> 
>> If they are the same, there should be nothing to worry about. If you
>> want the same results, use Reference BLAS (and LAPACK) from
>> www.netlib.org instead of ATLAS which you are probably using. The
>> SLICOT authors recommend the use of the reference implementations.
>> Correct results are more important than minor speed advantages of
>> automatically tuned linear algebra software, aren't they? :-)
> 
> I built the control package on my Debian system with libblas-dev
> installed and libatlas3-base, libatlas-dev, libopenblas-base, and
> libopenblas-dev removed.  I still get the same errors in the unit
> testings.  Here is the build log of the Debian package octave-control
> (version 2.3.53-1) with the same errors:
> 
> https://buildd.debian.org/status/fetch.php?pkg=octave-control&arch=i386&ver=2.3.53-1&stamp=1346708061
> 
> It seems that using the Reference BLAS is not enough for getting rid of
> the problem.
> 
> Rafael

You need Reference BLAS and Reference LAPACK. No ATLAS at all. Don't forget to rebuild Octave or to link control to the right libraries. If it still doesn't work, try to compile these libraries without optimizations.

Regards,
Lukas

Re: [OctDev] control 2.3.53 released

[marco a. <mar...@gm...>]

On 9/7/2012 1:46 PM, Lukas Reichlin wrote:
> On 07.09.2012, at 13:37, Rafael Laboissiere wrote:
>
>>
>> I built the control package on my Debian system with libblas-dev
>> installed and libatlas3-base, libatlas-dev, libopenblas-base, and
>> libopenblas-dev removed.  I still get the same errors in the unit
>> testings.  Here is the build log of the Debian package octave-control
>> (version 2.3.53-1) with the same errors:
>>
>> https://buildd.debian.org/status/fetch.php?pkg=octave-control&arch=i386&ver=2.3.53-1&stamp=1346708061
>>
>> It seems that using the Reference BLAS is not enough for getting rid of
>> the problem.
>>
>> Rafael
>
> You need Reference BLAS and Reference LAPACK. No ATLAS at all. Don't forget to rebuild Octave or to link control to the right libraries. If it still doesn't work, try to compile these libraries without optimizations.
>
> Regards,
> Lukas

on cygwin also with the Reference BLAS and Reference LAPACK the test
  fails. As we are likely obtaining equivalent representations,
what we can use as alternative test ?

Marco

Re: [OctDev] control 2.3.53 released

[Lukas R. <luk...@gm...>]

On 07.09.2012, at 13:57, marco atzeri wrote:

> On 9/7/2012 1:46 PM, Lukas Reichlin wrote:
>> On 07.09.2012, at 13:37, Rafael Laboissiere wrote:
>> 
>>> 
>>> I built the control package on my Debian system with libblas-dev
>>> installed and libatlas3-base, libatlas-dev, libopenblas-base, and
>>> libopenblas-dev removed.  I still get the same errors in the unit
>>> testings.  Here is the build log of the Debian package octave-control
>>> (version 2.3.53-1) with the same errors:
>>> 
>>> https://buildd.debian.org/status/fetch.php?pkg=octave-control&arch=i386&ver=2.3.53-1&stamp=1346708061
>>> 
>>> It seems that using the Reference BLAS is not enough for getting rid of
>>> the problem.
>>> 
>>> Rafael
>> 
>> You need Reference BLAS and Reference LAPACK. No ATLAS at all. Don't forget to rebuild Octave or to link control to the right libraries. If it still doesn't work, try to compile these libraries without optimizations.
>> 
>> Regards,
>> Lukas
> 
> on cygwin also with the Reference BLAS and Reference LAPACK the test
>  fails. As we are likely obtaining equivalent representations,
> what we can use as alternative test ?
> 
> Marco

Well, if only some signs change, use abs before comparing the matrices. If there are more general state transformations, I don't have a solution at hand. Maybe you can simply comment out the tests? (In case you don't like failing tests in packages maintained by you ;-)

Lukas