From: David B. <Dav...@mo...> - 2004-06-21 07:16:26
|
I believe it probably still works correctly for small values of n, since that was all I tested previously. Oh, well it looks like the method I used to create the generator matrix is too naive... Cheers David According to Quentin Spencer <qsp...@ie...> (on 06/18/04): > OK, I tested your changes to the coding stuff and this is what I found: > > bchpoly appears to give correct results for the cases I tested > cyclgen(255,bchpoly(255,247)) gives the correct result > cyclgen(255,bchpoly(255,239)) gives a matrix that is correct in the > first 8x8 submatrix, and zeros everywhere else !? > cyclpoly gives a vector containing all zeros for every input I tried. > > Well, I guess there's at least some progress since one case worked. I'm > sorry the news isn't better. > > -Quentin > > > David Bateman wrote: > > >According to Quentin Spencer <qsp...@ie...> (on 06/16/04): > > > > > >>David, > >> > >>Thanks. The updates fixed hammgen. However, now I've found another bug. > >>I don't know if it was there all along or newly introduced. The > >>following command should produce the 16x255 parity check matrix for a > >>BCH 2-error correcting code: > >>cyclgen(255,bchpoly(255,239)) > >> > >>The result instead is: > >>error: cyclgen: generator polynomial does not produce cyclic code > >> > >>I verified the resulting polynomial against MATLAB and they matched. > >> > >> > > > >Ok, I'm a bit draft. The test I added checks if the polynomial is primitive > >rather than just irreducible. I'd previously tried to adapt this test in > >the older code, but failed. > > > >So I went back to the basic implementation of dividing x^n-1 by the > >polynomial and checking that there was no remainder. It appears to > >work correctly for you test case now. Though maybe you want to give > >it a bit more testing.. Changes checked into the CVS > > > >Regards > >David > > > > > > > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference > Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer > Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA > REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND > _______________________________________________ > Octave-dev mailing list > Oct...@li... > https://lists.sourceforge.net/lists/listinfo/octave-dev -- David Bateman Dav...@mo... Motorola CRM +33 1 69 35 48 04 (Ph) Parc Les Algorithmes, Commune de St Aubin +33 1 69 35 77 01 (Fax) 91193 Gif-Sur-Yvette FRANCE The information contained in this communication has been classified as: [x] General Business Information [ ] Motorola Internal Use Only [ ] Motorola Confidential Proprietary |