Re: [OctDev] new release?

[David B. <Dav...@mo...>]

You are right that they need to be instantiated. But cat_ra is an
NDArray thing and so should be in "#ifdef HAVE_ND_ARRAYS ... #endif".
Apart from that it is fine...

I've applied this patch...

Cheers
David

According to Per Persson <per...@ma...> (on 06/16/04):
> 
> 
> >>
> >>I've committed this to the cvs, but unless you have access to the 
> >>developers
> >>site you won't see this change for a few hours. Could you check and 
> >>see
> >>that this fixes all the build problems you are/were having...
> >
> >That problem is gone! Now I see this (seems unrelated...)
> >ld: Undefined symbols:
> >int cat_ra<FixedPoint>(Array<FixedPoint>&, Array<FixedPoint> const&, 
> >int, int, int)
> >int cat_ra<FixedPointComplex>(Array<FixedPointComplex>&, 
> >Array<FixedPointComplex> const&, int, int, int)
> >make: *** [fixed.oct] Error 1
> 
> David,
> I think the following patch fixes the above problem.
> As I understand things, the templates need to be instantiated for the 
> corresponding symbols to be requested by the linker on OS X.
> Beware though that this is Cargo Cult programming, my C++ knowledge is 
> limited. Sanity check is necessary!!!
> 
> /Per
> 
> Index: main/fixed/Array-f.cc
> ===================================================================
> RCS file: /cvsroot/octave/octave-forge/main/fixed/Array-f.cc,v
> retrieving revision 1.2
> diff -u -d -b -w -u -w -r1.2 Array-f.cc
> --- main/fixed/Array-f.cc       26 May 2004 14:18:51 -0000      1.2
> +++ main/fixed/Array-f.cc       15 Jun 2004 21:57:06 -0000
> @@ -43,6 +43,10 @@
>  template class Array<FixedPointComplex>;
>  template class MArray<FixedPointComplex>;
> 
> +template int cat_ra (Array<FixedPoint>& ra, const Array<FixedPoint>& 
> ra_arg, \
> +                    int dim, int idx, int move);
> +template int cat_ra (Array<FixedPointComplex>& ra, const 
> Array<FixedPointComplex>& ra_arg, \
> +                    int dim, int idx, int move);
>  template int assign (Array<FixedPoint>&, const Array<FixedPoint>&);
>  template int assign (Array<FixedPointComplex>&, const 
> Array<FixedPoint>&);
>  template int assign (Array<FixedPointComplex>&,
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference
> Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer
> Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA
> REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND
> _______________________________________________
> Octave-dev mailing list
> Oct...@li...
> https://lists.sourceforge.net/lists/listinfo/octave-dev

-- 
David Bateman                                Dav...@mo...
Motorola CRM                                 +33 1 69 35 48 04 (Ph) 
Parc Les Algorithmes, Commune de St Aubin    +33 1 69 35 77 01 (Fax) 
91193 Gif-Sur-Yvette FRANCE

The information contained in this communication has been classified as: 

[x] General Business Information 
[ ] Motorola Internal Use Only 
[ ] Motorola Confidential Proprietary