From: c. <car...@gm...> - 2012-10-23 18:33:24
|
On 23 Oct 2012, at 17:27, Rafael Laboissiere wrote: > * c. <car...@gm...> [2012-10-22 12:21]: > >> New versions of the Forge packages bim (1.1.0) and msh (1.0.5) have been uploaded to the package release forum, and will soon be available for download from Octave-Forge. >> >> [snip] > > Thanks for this new release. I noticed a problem in it: the unit testing in the file msh3m_structured_mesh.m does not work. The patch attached below fixes the problem (there were two issues: tests were preceded by "%" instead of "%!" and there were spurious "=" signs after "assert"). However, the test fails with the following error message: > > octave:1> test msh3m_structured_mesh > ***** test > x = y = z = linspace (0,1,2); > [mesh] = msh3m_structured_mesh (x, y, z, 1, 1:6); > assert (columns (mesh.p), 8); > assert (columns (mesh.t), 6); > assert (columns (mesh.e), 12); > !!!!! test failed > `p' undefined near line 145 column 10 > > It seems that several variables (x, y, z, p, and sides) that used inside the subfunction __t6_connections__ are only locally defined in msh3m_structured_mesh. Rafael, Thank you very much for testing the package! I just uploaded a new version of the package in the release forum, could you please check if the problem is solved there? > This bug also affects the bim package. is this because of the dependency or is there similar bugs in bim? > Rafael c. |