Re: [OctDev] Analyze75

[adam a. <ada...@ho...>]

> From: car...@gm...
> Date: Tue, 2 Oct 2012 09:33:17 +0200
> Subject: Re: [OctDev] Analyze75
> To: ada...@ho...
> CC: oct...@li...
> 
> On 1 October 2012 22:30, adam aitkenhead <ada...@ho...> wrote:
> > I've just submitted analyze75write.m to SVN.
> 
> Nice, thank you. The code looks nice. I have added the function to the
> INDEX and NEWS file, and to the see also of the other functions.
> 
> Some tips, you don't need to check the value returned by isfield. If
> there is a field with that name, it will return true so "if (isfield
> (x, name))" is enough, no need to "if (isfield (x, name) == 1).
> 
> It would be good practice to also have analyze75filename deal with the
> filename part, just as it's doing for the other 2 functions. I'd guess
> analyze75filename would take an extra argument ("write", "info" or
> "read") for the part of checking if the file already exists. This
> would also allow to make it return the right error message with:
> 
> error ('analyze75%s: error message.', analyze75function)
> 
> Carnë

Those suggestions sound good, I can make those changes although I probably won't have time before the weekend.  If you're ready for the release of the image package then don't wait, as it won't affect functionality.
 
Thanks,
Adam