Re: [OctDev] Bug + Fix: Octave / Communications package / egolaydec.m

[Carnë D. <car...@gm...>]

Always make reply to all to include the mailing list and avoid top
posting (we do bottom posting on this mailing list)
http://www.idallen.com/topposting.html

On 21 August 2012 06:17,  <ro...@bu...> wrote:
> Quoting Carnë Draug <car...@gm...>:
>
>> On 20 August 2012 13:33, Roman Bumerl-Lexa <ro...@bu...> wrote:
>>>
>>> When using the golay decoder (an error correcting decoder), and there are
>>> more than the three allowed erroneous bits, the function crashes instead
>>> of
>>> setting the error flag.
>>>
>>> Golaytestcase.m:
>>>
>>> %octave
>>> % Testcase for crashing egolaydec.m
>>> x=[1 0 1 0 1 0 1 0 1 0 1 0 ];
>>> y=egolayenc(x); % create the encoded vector.
>>> y(17:2:23)=0;   % set four errors in this vector.
>>> [res,err]=egolaydec (y) % try to decode this erroneous vector.
>>>
>>>
>>>
>>> I contacted the author Annamalai, Muthiah
>>> <mut...@ma...>
>>> and he wrote :
>>>
>>> "Roman,
>>>
>>> I will not be able to debug the algorithm. But the error can be fixed by
>>> inserting the line,
>>>
>>> E=[S, zeros(1,12)];
>>>
>>> just after the statement
>>>
>>> done = 0;
>>>
>>> You may also submit a patch to the Octave project. I won't be able to
>>> do this.
>>>
>>> Thanks,
>>> -Muthu"
>>>
>>> I have inserted the line and it works now fine. I have tested it also for
>>> some other bitvectors containing more than the four errors used in my
>>> test
>>> case.
>>>
>>> Can anyone please fix this in the repository.
>>>
>>> Roman
>>
>>
>> Hi Roman,
>>
>> thank you for the fix. I have applied it now to the development tree.
>> Could you check if everything is right now?
>>
>> Carnë
>>
>
> Hi Carnë
>
> I have downloaded this actualized version of egolaydec.m from the link
> below, but it did not work. Maybe this is caused by running the older Octave
> Version 3.2.4.
> I will try it on another installation with Octave 3.6. I will inform you.
>
> http://octave.svn.sourceforge.net/viewvc/octave/trunk/octave-forge/main/comm/inst/egolaydec.m?revision=10893
>
>
>
> My working version consists of the egolaydec.m out of the following link,
> including the inserted line from Muthiah.
>
> http://sourceforge.net/projects/octave/files/Octave%20Forge%20Packages/Individual%20Package%20Releases/communications-1.1.1.tar.gz/download
>
> Roman

Hi Roman

maybe. I don't have 3.2 installed but it passes both tests in 3.6.2.

Carnë