[Octave-cvsupdate] SF.net SVN: octave:[7156] trunk/octave-forge/main/control/inst

[<par...@us...>]

Revision: 7156
          http://octave.svn.sourceforge.net/octave/?rev=7156&view=rev
Author:   paramaniac
Date:     2010-04-05 09:11:31 +0000 (Mon, 05 Apr 2010)

Log Message:
-----------
control: add two FIXME comments

Modified Paths:
--------------
    trunk/octave-forge/main/control/inst/@lti/sminreal.m
    trunk/octave-forge/main/control/inst/@ss/__minreal__.m

Modified: trunk/octave-forge/main/control/inst/@lti/sminreal.m
===================================================================
--- trunk/octave-forge/main/control/inst/@lti/sminreal.m	2010-04-05 00:56:37 UTC (rev 7155)
+++ trunk/octave-forge/main/control/inst/@lti/sminreal.m	2010-04-05 09:11:31 UTC (rev 7156)
@@ -43,4 +43,16 @@
 
   sys = __sysprune__ (sys, ":", ":", st_idx);
 
-endfunction
\ No newline at end of file
+endfunction
+
+
+## FIXME: algorithm returns wrong result for the example below
+##
+## P = ss (-2, 3, 4, 5)
+## C = inv (P)
+## L = P * C
+## Ls = sminreal (L)
+## bode (Ls)
+## 
+## Obviously, both magnitude and phase should be straight lines at 0 dB and 0 deg
+## In this case, sminreal shouldn't remove any states of L
\ No newline at end of file

Modified: trunk/octave-forge/main/control/inst/@ss/__minreal__.m
===================================================================
--- trunk/octave-forge/main/control/inst/@ss/__minreal__.m	2010-04-05 00:56:37 UTC (rev 7155)
+++ trunk/octave-forge/main/control/inst/@ss/__minreal__.m	2010-04-05 09:11:31 UTC (rev 7156)
@@ -68,4 +68,14 @@
   retsys = ss (A, B, C, sys.d);
   retsys.lti = sys.lti;  # retain i/o names and tsam
 
-endfunction
\ No newline at end of file
+endfunction
+
+
+## FIXME: algorithm fails for the example below
+##
+## P = ss (-2, 3, 4, 5)
+## C = inv (P)
+## L = P * C
+## Lm = minreal (L)
+##
+## Lm.d should be 1
\ No newline at end of file


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.