Jivin Pavel Roskin lays it down ...
> Hello!
>
> This piece of code in cryptodev_open() is wrong and unnecessary:
>
> if (filp->private_data) {
> printk("cryptodev: Private data already exists !\n");
> return(0);
> }
>
> This check is triggered on Linux 2.6.35 and 2.6.36-rc3 and causes the
> initialization to be cut short, which causes an oops on uninitialized
> list in subsequent calls.
>
> Generally, it's a bad idea to bail out from a function without returning
> an error code.
>
> I'm not sure if I'm supposed to send a patch considering that OCF is a
> patch itself.
We found that one too, just not in a release yet,
The current patch is attached :-)
Thanks,
Davidm
--
David McCullough, dav...@mc..., Ph:+61 734352815
McAfee - SnapGear http://www.mcafee.com http://www.uCdot.org
|
