Re: [Ocf-linux-users] ocf-bench and safe driver.

[David M. <Dav...@se...>]

Jivin Nawang Chhetan lays it down ...
> Hi David,
>                I started investigating what's going wrong with Ocf's
> SafeXcel driver i.e. safe.I noticed following things:
> 
> 1. safe only accepts crypto operations i.e. cryptop with crp-flags set
> either with CRYPTO_F_SKBUF or CRYPTO_F_IOV .

That is true,  adding support for contiguous buffers should be easy,
especially in the latest version of OCF.

> 2. Neither of the above two flags is set by ocf-bench, therefore the test
> application fails when used with safe driver.
> 
> I have questions regarding above observations:
> 1. I noticed this text in safe /* XXX we don't handle contiguous blocks! */
> safe driver. Why is this so ?

IIRC,  it just hasn't been implemented.  Looking through the code I
can't see any reason it can't be made to work.

> 2. Moreover, why is that only some driver check this flag(in there
> xxxx_process function) and while others don't ?

ixp4xx, safe and hifn all check these flags in various places.  hifn and
ixp4xx just happen to also implement the contiguous buffer options as
well.

It would be very easy to change ocf-bench to use IOV's, alternatively,
it would not be much harder to change safe.c to support contiguous
buffers.

Cheers,
Davidm


-- 
David McCullough,  dav...@se...,   Ph:+61 734352815
Secure Computing - SnapGear  http://www.uCdot.org http://www.cyberguard.com