Re: [Ocf-linux-users] EXPORT_SYMBOL(find_task_by_vpid) not needed for kernel <= 2.6.30

[David M. <dav...@mc...>]

Jivin Hauke Mehrtens lays it down ...
> In the patch linux-2.6.30-ocf.patch the adding of
> EXPORT_SYMBOL(find_task_by_vpid) is wrong, because kernel <= 2.6.30
> already have this and adding it twice causes a compiler error.
> 
> kernel/pid.c:395:1: error: redefinition of '__kstrtab_find_task_by_vpid'
> kernel/pid.c:386:1: note: previous definition of
> '__kstrtab_find_task_by_vpid' was here
> kernel/pid.c:395:1: error: redefinition of '__ksymtab_find_task_by_vpid'
> kernel/pid.c:386:1: note: previous definition of
> '__ksymtab_find_task_by_vpid' was here

What kernel version do you have ?
Which OCF release are you using ?

There are quite a lot of patches in the patches directory,  perhaps there is
a better choice.  Perhaps your kernel has already been patched once ?

If your kernel already supports it just undo that portion of the patch.
Its a fairly simple change.

> Why don't you have patches for every major kernel version and why is the
> ordering of the changes different from patch to patch.

We don't have every version for a number of reasons,  at the end of the day
thats just the way it is.  In a lot of cases the patch doesn't need updating
from release to release.  If you ask nicely it is possible for me to generate
a patch specific to just about any kernel revision, but it's not something I
do for fun.  Whenever I do generate one I add it to the patches directory
for others to use.

> This makes it hard to find the differences in the patches.

The patches are different as they are usually whatever came out of diff
process that I used at the time. It's not done on purpose, but when you are
hand assembling patches over a number of directories the diffs can get
reordered.

> Like the adding of EXPORT_SYMBOL(find_task_by_vpid); is in the top of
> linux-2.6.38-ocf.patch but in the bottom of linux-2.6.33-ocf.patch.

Its only a one line change,  if it is wrong for your kernel,  just add/delete
it as needed and feel free to pass on the required changes to the list for
others to learn from,

Thanks,
Davidm

-- 
David McCullough,      dav...@mc...,  Ph:+61 734352815
McAfee - SnapGear      http://www.mcafee.com         http://www.uCdot.org