[Ocf-linux-users] EXPORT_SYMBOL(find_task_by_vpid) not needed for kernel <= 2.6.30
Brought to you by:
david-m
From: Hauke M. <ha...@ha...> - 2011-08-11 10:20:14
|
In the patch linux-2.6.30-ocf.patch the adding of EXPORT_SYMBOL(find_task_by_vpid) is wrong, because kernel <= 2.6.30 already have this and adding it twice causes a compiler error. kernel/pid.c:395:1: error: redefinition of '__kstrtab_find_task_by_vpid' kernel/pid.c:386:1: note: previous definition of '__kstrtab_find_task_by_vpid' was here kernel/pid.c:395:1: error: redefinition of '__ksymtab_find_task_by_vpid' kernel/pid.c:386:1: note: previous definition of '__ksymtab_find_task_by_vpid' was here Why don't you have patches for every major kernel version and why is the ordering of the changes different from patch to patch. This makes it hard to find the differences in the patches. Like the adding of EXPORT_SYMBOL(find_task_by_vpid); is in the top of linux-2.6.38-ocf.patch but in the bottom of linux-2.6.33-ocf.patch. Hauke |