Re: [Ocf-linux-users] [PATCH - EP80579 driver update patch]

[Kennedy, B. <bre...@in...>]

>-----Original Message-----
>From: David McCullough [mailto:dav...@mc...]
>> >
>> >Did you just want to be able to identify the HW condition that causes
>> >this separate to an error ?
>>
>> Yes, we wanted to identify that the call was failing because of lack
>of driver support rather than due to bad inputs or some such thing.
>
>Ok,  I backed out the change in cryptodev so that a fail is still a fail
>at the syscall level, but we can detect this when the errno is the same
>as the kop_status.  Saves changes the driver API in any way which is
>kind of
>nice to have.
>
>Have a look at the attached patch and see if it does what you need,  if
>so
>then I'll commit that.
>

Hi Dave,

Sorry for the slow response! I like the use of errno, but a few questions:

1. Are similar changes going to be made for DSA sign/verify functionality?
2. It seems if the failure is in the driver(as oppose to OCF) for non algotithmic reasons, this will still show an algorithm fail. I think the patch code is meant to do that, but:
3. If the issue was because of algorithm fail (not the hardware), then the algorithm should not be run again in software (where essentially it should fail there for the same reason). It just slows down response time..

What do you think?

Regards,
Brendan
--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.