Re: [Ocf-linux-users] [PATCH - EP80579 driver update patch]

[David M. <dav...@mc...>]

Jivin Kennedy, Brendan lays it down ...
> >-----Original Message-----
> >From: David McCullough [mailto:dav...@mc...]
> >> Would it be possible to include the updated code in your later
> >releases
> >> of OCF?
> >
> >Done,  will be in the next release.
> >
> 
> Brilliant, thanks Dave!
> 
> >> There is a corresponding OpenSSL eng_cryptodev patch (third
> >attachment)
> >> if you want to check it out. This fixes some of the PKE ?? OCF calls.
> >
> >Ok,  some questions for you on this one.
> >
> >For the change:
> >+   } else if (ECANCELED == kop.crk_status) {
> >
> >This changes the behaviour for other drivers (safe/ixp) that will fall
> >back
> >to software on an ERANGE/E2BIG or any other error.
> >
> >Did you just want to be able to identify the HW condition that causes
> >this separate to an error ?  
> 
> Yes, we wanted to identify that the call was failing because of lack of driver support rather than due to bad inputs or some such thing.

Ok,  I backed out the change in cryptodev so that a fail is still a fail
at the syscall level, but we can detect this when the errno is the same
as the kop_status.  Saves changes the driver API in any way which is kind of
nice to have.

Have a look at the attached patch and see if it does what you need,  if so
then I'll commit that.

Thanks,
Davidm

-- 
David McCullough,      dav...@mc...,  Ph:+61 734352815
McAfee - SnapGear      http://www.mcafee.com         http://www.uCdot.org