Re: [Ocf-linux-users] [PATCH - EP80579 driver update patch]

[Kennedy, B. <bre...@in...>]

>-----Original Message-----
>From: David McCullough [mailto:dav...@mc...]
>> Would it be possible to include the updated code in your later
>releases
>> of OCF?
>
>Done,  will be in the next release.
>

Brilliant, thanks Dave!

>> There is a corresponding OpenSSL eng_cryptodev patch (third
>attachment)
>> if you want to check it out. This fixes some of the PKE ?? OCF calls.
>
>Ok,  some questions for you on this one.
>
>For the change:
>+   } else if (ECANCELED == kop.crk_status) {
>
>This changes the behaviour for other drivers (safe/ixp) that will fall
>back
>to software on an ERANGE/E2BIG or any other error.
>
>Did you just want to be able to identify the HW condition that causes
>this separate to an error ?  

Yes, we wanted to identify that the call was failing because of lack of driver support rather than due to bad inputs or some such thing.

> If so,  then something like:
>
>  } else if (kop.crk_status) {
>
>Should do.  I don't think ECANCELED needs to be any different than any
>other
>driver error,  but perhaps I am missing something.
>
>If this sounds ok I will fix up teh patch on the way in, 

This works for us. I think we just didn't want to lose granularity if some unexpected error happened in our driver, but it should print to /var/log/messages in that case anyway.

Thanks,
Regards,
Brendan
--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.