[Ocf-linux-users] crypto_dispatch update for 20080917

[Kennedy, B. <bre...@in...>]

Hi All,

I am having trouble understanding the update to the crypto_dispatch function in crypto.c for ocf-linux-20080917 from ocf-linux-2071215:

2007 code:
                if (!cap->cc_qblocked) {
                        result = crypto_invoke(cap, crp, 0);
                        if (result != ERESTART)
                                return (result);

2008 code:
                        result = crypto_invoke(cap, crp, 0);
                        CRYPTO_Q_LOCK();
                        if (result != ERESTART)
                                crypto_drivers[hid].cc_qblocked = 0;

In the 2008 code an error is not returned to cryptodev.c if crypto_invoke returns an error code.
Should we now always call crypto_done() if there is a fail in the driver invoke function?

I ask because I've tried this but am getting a soft lockup when using crypto-tools and testing some fail case scenarios if I set the crp->etype before calling crypto-done.

Best Regards,
Brendan

------------------------------------------------
Brendan Kennedy
Intel Shannon Ltd.,
Ireland.

Email: bre...@in...<mailto:bre...@in...>
------------------------------------------------

---------------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: One Spencer Dock, North Wall Quay, Dublin 1
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.