Re: [Ocf-linux-users] OCF 20080704 and 2.6.21.6 Kernel

[David M. <Dav...@se...>]

Jivin "Ramon Schönborn" lays it down ...
> Hi David & List,
> > > > > I guess there's a bug in pfkey_v2_parser.c, btw. If you compare the
> > > > > old 2.4.8 Version with the current one, a pair of curly braces
> > changed
> > > > > the semantic.
> > > > > >From Line 2126 it should be like:
> > > > > -               if ((error = ipsec_cleareroutes())) {
> > > > > +               if ((error = ipsec_cleareroutes()))
> > > > >                         KLIPS_PRINT(debug_pfkey,
> > > > >                                    
> > "klips_debug:pfkey_x_delflow_parse:
> > > > "
> > > > >                                     "cleareroutes returned %d.\n",
> > > > error);
> > > > >                         SENDERR(-error);
> > > > > -               }
> > > > > +
> > > >
> > > > That is definately a problem but it looks like we already found it :-)
> > > > My code has the fix so I am guessing you need to try 2.6.16dr4,  which
> > > > is what I have running here.  It has settled down now but there was a
> > "dr"
> > > > release every day there for a bit ;-)
> > > 
> > > isnt fixed in 2.6.16dr4 yet. I forgot to mention that i'm already
> > testing
> > > 2.6.16dr4 too.
> > 
> > Ok,  I misread what you were saying and I see the code change.
> > 
> > Is this change causing you a problem ?  IMO is looks like it was always
> > a bug as the code hasn't detected any errors yet does a jump to errlab
> > by calling SENDERR(-0).
> > 
> > I'll copy Paul Wouters at Xelerance to see what his thoughts are.
>
> it was causing me the problem that "ipsec eroute --clear" didnt work 
> anymore. It seems to me that calling SENDERR(-0) was just an quick and
> dirty - though working -  trick to finish the "clear"-Request.

Its definately possible,  but it didn't look right.  I imagine I changed it
during the big ocf-merge because it didn't look right.

If it is causing you problems then I say back out the change ;-)

Cheers,
Davidm

-- 
David McCullough,  dav...@se...,   Ph:+61 734352815
Secure Computing - SnapGear  http://www.uCdot.org   http://www.snapgear.com