From: Patrick M D. <pa...@wa...> - 2001-10-07 01:52:13
|
I've been working on e-mail address support today and have a couple of suggestions: - I think it may be good to factor out the address support to a Netaddress module. It seems to distract from the focus of the Netmessage module. - Object-based representations for addresses may not be the best idea. I forgot that they don't support equality, which makes it impossible to use them as keys and it also complicates testing. I would recommend switching back to a record based structure: type mailbox = { name: string option; route: string list; spec: addr_spec; } type t = [ `Mailbox of mailbox | `Group of string * mailbox list ] Patrick |