ocaml-lib-devel

[Ocaml-lib-devel] Feature request: ?cmp parameter for PMap.find

[Denis B. <db...@gm...>]

Would it be possible to have PMap.find take an optional comparison
parameter? I was just using PMap in some OCaml code and discovered
that, since my keys contain Big_int.big_ints, I need to have a custom
comparator for the one find that I do. It would have been nice to have
that feature built-in.

-Denis

Re: [Ocaml-lib-devel] Feature request: ?cmp parameter for PMap.find

[Brian H. <bh...@sp...>]

On Thu, 16 Nov 2006, Denis Bueno wrote:

> Would it be possible to have PMap.find take an optional comparison
> parameter? I was just using PMap in some OCaml code and discovered
> that, since my keys contain Big_int.big_ints, I need to have a custom
> comparator for the one find that I do. It would have been nice to have
> that feature built-in.

In this case, why not just use the standard library map?

Brian

Re: [Ocaml-lib-devel] Feature request: ?cmp parameter for PMap.find

[Martin J. <mar...@em...>]

On Thu, 16 Nov 2006, Denis Bueno wrote:

> Would it be possible to have PMap.find take an optional comparison
> parameter? I was just using PMap in some OCaml code and discovered
> that, since my keys contain Big_int.big_ints, I need to have a custom
> comparator for the one find that I do. It would have been nice to have
> that feature built-in.

Maybe I am missing something, but you already give a comparison function
when you create the map (PMap.create). This is where you would pass your
custom comparison function rather than Pervasives.compare. You can't
change it later.


Martin

--
Martin Jambon, PhD
http://martin.jambon.free.fr

Re: [Ocaml-lib-devel] Feature request: ?cmp parameter for PMap.find

[Denis B. <db...@gm...>]

On 11/17/06, Martin Jambon <mar...@em...> wrote:
> Maybe I am missing something, but you already give a comparison function
> when you create the map (PMap.create). This is where you would pass your
> custom comparison function rather than Pervasives.compare. You can't
> change it later.

I have never used that function. I always insert elements into
existing maps, starting with a PMap.empty.

-Denis

Re: [Ocaml-lib-devel] Feature request: ?cmp parameter for PMap.find

[Martin J. <mar...@em...>]

On Fri, 17 Nov 2006, Denis Bueno wrote:

> On 11/17/06, Martin Jambon <mar...@em...> wrote:
> > Maybe I am missing something, but you already give a comparison function
> > when you create the map (PMap.create). This is where you would pass your
> > custom comparison function rather than Pervasives.compare. You can't
> > change it later.
>
> I have never used that function. I always insert elements into
> existing maps, starting with a PMap.empty.

Well, start with (PMap.create your_compare) then.


Martin

--
Martin Jambon, PhD
http://martin.jambon.free.fr