ocaml-lib-devel

[Ocaml-lib-devel] [PATCH] bitSet.ml/bitSet.mli: added diff, diff_sym, inter and union

[Janne H. <ja...@hy...>]

This patch adds new functionality to BitSet.  These functions were 
discussed earlier on this mailing lists.

The patch does not modify old functions, just adds new ones.  A careful 
reader will note that it is doing a bit of extra work.. I doubt it will 
make much of a difference, but perhaps I can optimize these later on.

It has been tested with the testing suite.

If the diff is OK, I can commit to CVS myself (testers included).

ciao,
janne

Re: [Ocaml-lib-devel] [PATCH] bitSet.ml/bitSet.mli: added diff, diff_sym, inter and union

[Bardur A. <oca...@sc...>]

On Tue, Dec 21, 2004 at 11:28:58PM +0200, Janne Hellsten wrote:

> This patch adds new functionality to BitSet.  These functions were 
> discussed earlier on this mailing lists.
> 
> The patch does not modify old functions, just adds new ones.  A careful 
> reader will note that it is doing a bit of extra work.. I doubt it will 
> make much of a difference, but perhaps I can optimize these later on.
> 
> It has been tested with the testing suite.
> 
> If the diff is OK, I can commit to CVS myself (testers included).

Just a tiny naming nit: diff_sym should probably be called
sym_diff since that more closely resembles the full name,
"symmetric difference".

The code looks fine to me.

-- 
Bardur Arantsson
<ba...@im...>
<ba...@sc...>

- I'm sorry I lied to you, Marge, but this gun had a hold on me.
I felt this incredible surge of power, like God must feel when
he's holding a gun.
                                     Homer Simpson | The Simpsons

Re: [Ocaml-lib-devel] [PATCH] bitSet.ml/bitSet.mli: added diff, diff_sym, inter and union

[Janne H. <ja...@hy...>]

OK, renamed diff_sym to sym_diff and committed.

ciao,
janne

Bardur Arantsson wrote:
> On Tue, Dec 21, 2004 at 11:28:58PM +0200, Janne Hellsten wrote:
> 
> 
>>This patch adds new functionality to BitSet.  These functions were 
>>discussed earlier on this mailing lists.
>>
>>The patch does not modify old functions, just adds new ones.  A careful 
>>reader will note that it is doing a bit of extra work.. I doubt it will 
>>make much of a difference, but perhaps I can optimize these later on.
>>
>>It has been tested with the testing suite.
>>
>>If the diff is OK, I can commit to CVS myself (testers included).
> 
> 
> Just a tiny naming nit: diff_sym should probably be called
> sym_diff since that more closely resembles the full name,
> "symmetric difference".
> 
> The code looks fine to me.
> 

Re: [Ocaml-lib-devel] [PATCH] bitSet.ml/bitSet.mli: added diff, diff_sym, inter and union

[skaller <sk...@us...>]

On Wed, 2004-12-22 at 08:28, Janne Hellsten wrote:
> This patch adds new functionality to BitSet.  

Just curious -- you have 'diff' and 'diff_sym'.
My Ocaml 3.0.8 manual says Set just has 'diff' and describes
it as 'set difference'.

Which function is the standard Set,, subtraction or symmetric
difference?

What does ExtSet have?

Woops there isn't one .. how about pSet .. Woops there isn't one..

Why isn't there a pSet (polymorphic set)?
> 
> ______________________________________________________________________
Otherwise .. I vote for committing your changes.

-- 
John Skaller, mailto:sk...@us...
voice: 061-2-9660-0850, 
snail: PO BOX 401 Glebe NSW 2037 Australia
Checkout the Felix programming language http://felix.sf.net

Re: [Ocaml-lib-devel] [PATCH] bitSet.ml/bitSet.mli: added diff, diff_sym, inter and union

[Janne H. <ja...@hy...>]

> Just curious -- you have 'diff' and 'diff_sym'.
> My Ocaml 3.0.8 manual says Set just has 'diff' and describes
> it as 'set difference'.
> 
> Which function is the standard Set,, subtraction or symmetric
> difference?

ExtLib's BitSet had differentiate_sym, so I decided it's better to add 
non-destructive version of that as well (sym_diff).

sym_diff is "set symmetriccal difference", which is corresponds to XOR 
in Boolean logic.

Set.diff is subtraction.

ciao,
janne